From: Richard Biener <richard.guenther@gmail.com>
To: Carlos O'Donell <carlos@redhat.com>,gcc@gcc.gnu.org,Thomas
Schwinge
<thomas@codesourcery.com>,gdb@sourceware.org,binutils@sourceware.org,libc-alpha@sourceware.org
Subject: Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc.
Date: Thu, 21 Sep 2017 18:38:00 -0000 [thread overview]
Message-ID: <2DF772C0-ACFE-4894-A444-8DB2AF9518E1@gmail.com> (raw)
In-Reply-To: <4056e466-3055-455b-9922-55497d21fd80@redhat.com>
On September 21, 2017 8:18:39 PM GMT+02:00, Carlos O'Donell <carlos@redhat.com> wrote:
>On 09/21/2017 11:56 AM, Richard Biener wrote:
>>> Not yet.
>>
>> I think given an OK from an official reviewer entitles you to commit
>> it indeed IS matching the formal statement. It better does...
>
>Isn't it better to be explicit about this; rather than assuming?
>
>>> All of this is nothing compared to the work of doing the review.
>>
>> Depends on the complexity of the patch...
>
>... depends on your ability to create quick paste hot keys :}
Indeed. Any idea how to do that with K9 / SwiftKey?
Richard.
next prev parent reply other threads:[~2017-09-21 18:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 16:50 Thomas Schwinge
2017-09-21 17:38 ` Carlos O'Donell
2017-09-21 17:56 ` Richard Biener
2017-09-21 18:18 ` Carlos O'Donell
2017-09-21 18:38 ` Richard Biener [this message]
2017-09-21 19:54 ` Carlos O'Donell
2017-09-22 18:38 ` Thomas Schwinge
2017-10-04 13:47 ` Thomas Schwinge
2017-10-19 17:06 ` Thomas Schwinge
2017-10-19 17:08 ` Carlos O'Donell
2017-10-19 22:40 ` Martin Sebor
2017-10-20 10:13 ` Joseph Myers
2017-10-20 10:36 ` Carlos O'Donell
2017-10-20 10:40 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2DF772C0-ACFE-4894-A444-8DB2AF9518E1@gmail.com \
--to=richard.guenther@gmail.com \
--cc=binutils@sourceware.org \
--cc=carlos@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=gdb@sourceware.org \
--cc=libc-alpha@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).