* [PATCH] tests/common.sh: Find ss on the PATH
@ 2023-12-25 15:45 Mark Wielaard
2024-01-02 9:58 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2023-12-25 15:45 UTC (permalink / raw)
To: annobin; +Cc: David Abdurachmanov, Mark Wielaard
On Fedora based systems ss is installed in /usr/sbin.
On Debian based systems ss is installed in /usr/bin.
Either system has both /usr/bin and usr/sbin on the default PATH.
With this the debian-i386 and ubuntu-riscv CI builders are zero fail:
https://builder.sourceware.org/buildbot/#/builders?tags=annobin
---
tests/common.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/common.sh b/tests/common.sh
index 9699386..4c55165 100644
--- a/tests/common.sh
+++ b/tests/common.sh
@@ -19,7 +19,7 @@ GCC=${GCC:-gcc}
OBJCOPY=${OBJCOPY:-objcopy}
PLUGIN=${PLUGIN:-../../gcc-plugin/.libs/annobin.so}
READELF=${READELF:-readelf}
-SS=${SS:-/usr/sbin/ss}
+SS=${SS:-ss}
STRIP=${STRIP:-strip}
# TEST_NAME must be set before including this
--
2.39.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/common.sh: Find ss on the PATH
2023-12-25 15:45 [PATCH] tests/common.sh: Find ss on the PATH Mark Wielaard
@ 2024-01-02 9:58 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2024-01-02 9:58 UTC (permalink / raw)
To: Mark Wielaard, annobin; +Cc: David Abdurachmanov
Hi Mark,
> On Fedora based systems ss is installed in /usr/sbin.
> On Debian based systems ss is installed in /usr/bin.
> Either system has both /usr/bin and usr/sbin on the default PATH.
>
> With this the debian-i386 and ubuntu-riscv CI builders are zero fail:
> https://builder.sourceware.org/buildbot/#/builders?tags=annobin
Patch approved and applied. Thanks!
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-02 9:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-25 15:45 [PATCH] tests/common.sh: Find ss on the PATH Mark Wielaard
2024-01-02 9:58 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).