public inbox for annobin@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: annobin@sourceware.org, Matthias Klose <doko@debian.org>
Subject: Re: ubuntu-riscv Re: ☠ Buildbot (Sourceware): annobin - failed test (failure) (master)
Date: Fri, 8 Mar 2024 15:28:50 +0000	[thread overview]
Message-ID: <a6621c03-60f4-4fa4-bda2-2e9124ba5abb@redhat.com> (raw)
In-Reply-To: <e1aab6f61e2dfbc6271a3854fff36c4db3ecfbee.camel@klomp.org>

Hi Mark,

> It was installed, but it doesn't provide LLVMgold.so, just a dangling
> symlink:

> I am not sure that is a packaging error or that LLVMgold just isn't
> supported on riscv.

It isn't supported:

   https://ubuntuforums.org/showthread.php?t=2476019

Basically since gold does not support the Risc-V architecture, the plugin
is unavailable.  Which in turn means that LTO is not support.  (For clang,
on risc-v).

I have disabled lto when building the plugin, for now.  But the problem
is that when annocheck is run over the plugin (eg in Fedora's gating CI)
it will FAIL because LTO is not enabled...

Could you test something for me please ?  Is it possible to build the
clang plugin on risc-v, but using the ld.bfd linker ?  ie: does this patch
work:

diff --git a/clang-plugin/Makefile.in b/clang-plugin/Makefile.in
index 1fc45c0..325d1e9 100644
--- a/clang-plugin/Makefile.in
+++ b/clang-plugin/Makefile.in
@@ -14,6 +14,7 @@ PLUGIN_OPTIONS = \
    -fPIC \
    -Wall \
    -O2 \
+  -flto -fuse-ld=ld.bfd \
    -g -grecord-gcc-switches \
    -Wl,--build-id=md5 \
    -Wl,-z,now

Cheers
   Nick


  reply	other threads:[~2024-03-08 15:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 19:22 builder
2024-03-05 21:05 ` Mark Wielaard
2024-03-06 10:45   ` Nick Clifton
2024-03-07  0:05     ` Mark Wielaard
2024-03-07 13:34       ` ubuntu-riscv " Mark Wielaard
2024-03-08 15:28         ` Nick Clifton [this message]
2024-03-08 17:19           ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6621c03-60f4-4fa4-bda2-2e9124ba5abb@redhat.com \
    --to=nickc@redhat.com \
    --cc=annobin@sourceware.org \
    --cc=doko@debian.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).