public inbox for annobin@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Add check for binutils-devel demangle.h header
@ 2023-04-13 15:28 Mark Wielaard
  2023-04-13 19:07 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2023-04-13 15:28 UTC (permalink / raw)
  To: annobin; +Cc: Mark Wielaard

Make sure demangle.h is available during configure to prevent build
issues later.

Also remove check for AC_HEADER_SYS_WAIT which isn't actually used.
---
 configure.ac | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 36d252d..7ed31fd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -149,7 +149,13 @@ ACX_LT_HOST_FLAGS
 AC_SUBST(target_noncanonical)
 AC_TYPE_INT64_T
 AC_TYPE_UINT64_T
-AC_HEADER_SYS_WAIT
+
+# Check for demangle.h header, note the "empty" includes to make sure
+# libiberty.h isn't getting confused by the use of configure detected
+# include headers.
+AC_CHECK_HEADER([demangle.h], [],
+		[AC_MSG_ERROR([binutils-devel demangle.h header not found])],
+		[ ])
 
 AM_CONDITIONAL([COND_DOCS],       [test "$with_docs" != no])
 AM_CONDITIONAL([COND_TESTS],      [test "$with_tests" != no])
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add check for binutils-devel demangle.h header
  2023-04-13 15:28 [PATCH] Add check for binutils-devel demangle.h header Mark Wielaard
@ 2023-04-13 19:07 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2023-04-13 19:07 UTC (permalink / raw)
  To: Mark Wielaard, annobin

Hi Mark,

> Make sure demangle.h is available during configure to prevent build
> issues later.

Thanks for doing this.  I have gone ahead and applied your patch.
It is now in version 12.03.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-13 19:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-13 15:28 [PATCH] Add check for binutils-devel demangle.h header Mark Wielaard
2023-04-13 19:07 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).