[SCM] archer-pmuldoon-python-breakpoints: Add review changes from March 11th 2011

[SCM] archer-pmuldoon-python-breakpoints: Add review changes from March 11th 2011

[pmuldoon]

The branch, archer-pmuldoon-python-breakpoints has been updated
       via  d0f53df3b579f1eac0232146e07e6fefc9ac39e8 (commit)
      from  347237ef673818673265bcc7e29a90ec5b2960a9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit d0f53df3b579f1eac0232146e07e6fefc9ac39e8
Author: Phil Muldoon <pmuldoon@redhat.com>
Date:   Mon Mar 14 13:57:16 2011 +0000

    Add review changes from March 11th 2011

-----------------------------------------------------------------------

Summary of changes:
 gdb/breakpoint.c           |    2 +-
 gdb/doc/gdb.texinfo        |    2 +-
 gdb/python/py-breakpoint.c |    3 ++-
 3 files changed, 4 insertions(+), 3 deletions(-)

First 500 lines of diff:
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 27c4ce0..85eba8c 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -650,7 +650,7 @@ condition_command (char *arg, int from_tty)
 	   the CLI are mutually exclusive.  */
 	if (b->py_bp_object
 	    && gdbpy_breakpoint_has_py_cond (b->py_bp_object))
-	  error (_("Cannot set a condition where a Python 'stop' " \
+	  error (_("Cannot set a condition where a Python 'stop' "
 		   "method has been defined in the breakpoint."));
 	set_breakpoint_condition (b, p, from_tty);
 	return;
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 2c835b2..01455d1 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -23119,7 +23119,7 @@ assumed to be a @var{WP_WRITE} class.
 The @code{gdb.Breakpoint} class can be sub-classed and, in
 particular, you may choose to implement the @code{stop} method.
 If this method is defined as a sub-class of @code{gdb.Breakpoint},
-it will be called when the inferior stops at any location of a
+it will be called when the inferior reaches any location of a
 breakpoint which instantiates that sub-class.  If the method returns
 @code{True}, the inferior will be stopped at the location of the
 breakpoint, otherwise the inferior will continue.
diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c
index 524380f..0c21bfc 100644
--- a/gdb/python/py-breakpoint.c
+++ b/gdb/python/py-breakpoint.c
@@ -41,7 +41,7 @@ static int bppy_live;
 static breakpoint_object *bppy_pending_object;
 
 /* Function that is called when a Python condition is evaluated.  */
-char *stop_func = "stop";
+static char * const stop_func = "stop";
 
 struct breakpoint_object
 {
@@ -898,6 +898,7 @@ gdbpy_initialize_breakpoints (void)
 /* Helper function that overrides this Python object's
    PyObject_GenericSetAttr to allow extra validation of the attribute
    being set.  */
+
 static int 
 local_setattro (PyObject *self, PyObject *name, PyObject *v)
 {


hooks/post-receive
--
Repository for Project Archer.