public inbox for archer-commits@sourceware.org
help / color / mirror / Atom feed
* [SCM]  archer-sergiodj-stap: Removing testing statement; using gdb_assert instead of internal_error.
@ 2011-03-17 21:04 sergiodj
  0 siblings, 0 replies; only message in thread
From: sergiodj @ 2011-03-17 21:04 UTC (permalink / raw)
  To: archer-commits

The branch, archer-sergiodj-stap has been updated
       via  3d0f221b6a17aa114b9e1bf52f62306ceae9b72d (commit)
      from  78e2c2646895feb9ba33b8266345dba9840e7666 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit 3d0f221b6a17aa114b9e1bf52f62306ceae9b72d
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date:   Thu Mar 17 18:03:58 2011 -0300

    Removing testing statement; using gdb_assert instead of internal_error.

-----------------------------------------------------------------------

Summary of changes:
 gdb/elfread.c    |    3 ---
 gdb/stap-probe.c |   10 ++++------
 2 files changed, 4 insertions(+), 9 deletions(-)

First 500 lines of diff:
diff --git a/gdb/elfread.c b/gdb/elfread.c
index 64a27ab..37e19e7 100644
--- a/gdb/elfread.c
+++ b/gdb/elfread.c
@@ -1247,9 +1247,6 @@ elf_get_probes (struct objfile *objfile, int *num_probes)
 
   *num_probes = probes_per_objfile->stap_num_probes;
 
-  /* FIXME : THIS IS JUST FOR TESTING */
-  elf_get_probe_argument_count (objfile, probes_per_objfile->probes);
-
   return ret;
 }
 
diff --git a/gdb/stap-probe.c b/gdb/stap-probe.c
index ad4e754..7613400 100644
--- a/gdb/stap-probe.c
+++ b/gdb/stap-probe.c
@@ -665,12 +665,10 @@ stap_fetch_reg_value (struct stap_evaluation_info *eval_info,
   char regname[REG_NAME_MAX_SIZE + 1];
   int len, regnum, indirect_p = 0;
   struct value *ret;
-
-  if (!s || !*s)
-    /* The function which called us did not check if the expression
-       buffer was empty.  */
-    internal_error (__FILE__, __LINE__,
-		    _("Invalid call to function."));
+  
+  /* The function which called us did not check if the expression
+     buffer was empty.  */
+  gdb_assert (s && *s);
 
   /* Valid register name on x86 platforms are:
 


hooks/post-receive
--
Repository for Project Archer.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-03-17 21:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-17 21:04 [SCM] archer-sergiodj-stap: Removing testing statement; using gdb_assert instead of internal_error sergiodj

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).