public inbox for archer-commits@sourceware.org
help / color / mirror / Atom feed
* [SCM]  archer-jankratochvil-entryval: whitespace
@ 2011-07-08 14:57 jkratoch
  0 siblings, 0 replies; only message in thread
From: jkratoch @ 2011-07-08 14:57 UTC (permalink / raw)
  To: archer-commits

The branch, archer-jankratochvil-entryval has been updated
       via  ab247a5ebe8f153d10d53e830753309c3527c1b6 (commit)
       via  91529124962edf008a27911cad8724a500eb7dad (commit)
      from  6fbcc79ad9b4076c93d4d9c660d654eb977da02f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit ab247a5ebe8f153d10d53e830753309c3527c1b6
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Fri Jul 8 16:57:43 2011 +0200

    whitespace

commit 91529124962edf008a27911cad8724a500eb7dad
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Fri Jul 8 15:43:16 2011 +0200

    cmt

-----------------------------------------------------------------------

Summary of changes:
 gdb/dwarf2expr.c |    1 -
 gdb/dwarf2loc.c  |   15 +++++++++------
 2 files changed, 9 insertions(+), 7 deletions(-)

First 500 lines of diff:
diff --git a/gdb/dwarf2expr.c b/gdb/dwarf2expr.c
index 2e70171..6897fb8 100644
--- a/gdb/dwarf2expr.c
+++ b/gdb/dwarf2expr.c
@@ -1273,7 +1273,6 @@ execute_stack_op (struct dwarf_expr_context *ctx,
 	    CORE_ADDR deref_size;
 
 	    op_ptr = read_uleb128 (op_ptr, op_end, &len);
-	    /* FIXME: OP_PTR overflow.  */
 	    if (op_ptr + len > op_end)
 	      error (_("DW_OP_GNU_entry_value: too few bytes available."));
 
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index ed42b5d..96a9258 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -617,7 +617,9 @@ chain_candidate (struct gdbarch *gdbarch, struct call_site_chain **resultp,
   return 0;
 }
 
-/* FIXME: gdbarch should be per-frame across this function.  */
+/* Create and return call_site_chain for CALLER_PC and CALLEE_PC.  All the
+   assumed frames between them use GDBARCH.  Any exceptions are normally
+   thrown.  */
 
 static struct call_site_chain *
 call_site_find_chain_1 (struct gdbarch *gdbarch, CORE_ADDR caller_pc,
@@ -716,9 +718,6 @@ call_site_find_chain_1 (struct gdbarch *gdbarch, CORE_ADDR caller_pc,
 		 It would not discover anything new.  */
 	      if (*slot == NULL)
 		{
-		  /* FIXME: CORE_ADDR should be in the CHAIN vector to get
-		     freed appropriately during the traversal.  */
-
 		  *slot = obstack_alloc (&addr_obstack, sizeof (**slot));
 		  **slot = target_call_site_addr;
 
@@ -767,6 +766,10 @@ call_site_find_chain_1 (struct gdbarch *gdbarch, CORE_ADDR caller_pc,
   return retval2;
 }
 
+/* Create and return call_site_chain for CALLER_PC and CALLEE_PC.  All the
+   assumed frames between them use GDBARCH.  If valid call_site_chain cannot be
+   constructed return NULL.  */
+
 struct call_site_chain *
 call_site_find_chain (struct gdbarch *gdbarch, CORE_ADDR caller_pc,
 		      CORE_ADDR callee_pc)
@@ -878,8 +881,8 @@ dwarf_expr_regnum_entry_value (struct frame_info *frame, int regnum,
     {
       dwarf_block = parameter->call_site_value;
       if (dwarf_block == NULL)
-	error (_("Cannot resolve DW_AT_GNU_call_site_value for register %d"
-		 " at DW_TAG_GNU_call_site %s"),
+	error (_("Cannot resolve DW_AT_GNU_call_site_value for register %d "
+		 "at DW_TAG_GNU_call_site %s"),
 	       regnum, paddress (caller_gdbarch, caller_pc));
     }
   else


hooks/post-receive
--
Repository for Project Archer.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-07-08 14:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-08 14:57 [SCM] archer-jankratochvil-entryval: whitespace jkratoch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).