Re: Patch for pascal-dynamic arrays

[Joost van der Sluis <joost@cnoc.nl>]

On Sat, 2010-05-15 at 00:46 +0200, Jan Kratochvil wrote:
> On Fri, 14 May 2010 23:57:30 +0200, Joost van der Sluis wrote:
> > I can't apply it.
> 
> OK, sorry for the inconvenience.

No problem, I've got it to work!

In principle I did the same as you suggested. Eventually I've applied
the patch 'manually' by copy-pasting the right bits. I think there were
some eol-differences, or something.

But it works great. I don't understand the cleanup-bit entirely, but
you've found another solution for this problem I didn't think of. Thanks
for the help.

A few details, though.

Take a look a this bug-report
(http://sourceware.org/bugzilla/show_bug.cgi?id=11492) about the
identification of arrays. It has a better fix for that, and it avoids
problems when merging this later.

And when you do a 'print s' when the breakpoint is before line 80. (In
arrays.pas) you get 'Object is not allocated'. In theory this is true,
but unallocated strings in pascal are handled as empty strings (''). But
that's a minor issue that's fixable in p-valprint only.

The next challenge is to print individual items from the array. (print
DynArrStr[3]). But that didn't work with my patch either. And I think
that with your solution it's easier to implement this.

Again, thanks for the help, this patch works perfectly.

Joost.