* [archer-tromey-call-frame-cfa] [patch] Fix compilation
@ 2009-07-29 19:17 Jan Kratochvil
2009-07-29 19:18 ` [archer-tromey-call-frame-cfa] [patch] Fix compilation [resent] Jan Kratochvil
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kratochvil @ 2009-07-29 19:17 UTC (permalink / raw)
To: Tom Tromey; +Cc: archer
Hi Tom,
dwarf2-frame.c: In function ‘dwarf2_frame_cfa’:
dwarf2-frame.c:1257: error: passing argument 2 of ‘frame_base_is’ discards qualifiers from pointer target type
frame.h:702: note: expected ‘struct frame_base *’ but argument is of type ‘const struct frame_base *’
Fedora 11 gcc-4.4.0-4.x86_64
more curious it did not happen to you. OK to check-in?
Thanks,
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [archer-tromey-call-frame-cfa] [patch] Fix compilation [resent]
2009-07-29 19:17 [archer-tromey-call-frame-cfa] [patch] Fix compilation Jan Kratochvil
@ 2009-07-29 19:18 ` Jan Kratochvil
2009-07-29 19:23 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kratochvil @ 2009-07-29 19:18 UTC (permalink / raw)
To: Tom Tromey; +Cc: archer
[this time with the patch]
Hi Tom,
dwarf2-frame.c: In function ‘dwarf2_frame_cfa’:
dwarf2-frame.c:1257: error: passing argument 2 of ‘frame_base_is’ discards qualifiers from pointer target type
frame.h:702: note: expected ‘struct frame_base *’ but argument is of type ‘const struct frame_base *’
Fedora 11 gcc-4.4.0-4.x86_64
more curious it did not happen to you. OK to check-in?
Thanks,
Jan
commit e1849a4a9801313f99fa3faee8a88267651d6217
Author: Jan Kratochvil <jkratoch@host1.dyn.jankratochvil.net>
Date: Wed Jul 29 21:13:07 2009 +0200
gdb/
* frame.c (frame_base_is): Make the BASE parameter const.
* frame.c (frame_base_is): Likewise.
diff --git a/gdb/frame.c b/gdb/frame.c
index c009288..afa6e2a 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1847,7 +1847,7 @@ get_frame_args_address (struct frame_info *fi)
otherwise. */
int
-frame_base_is (struct frame_info *fi, struct frame_base *base)
+frame_base_is (struct frame_info *fi, const struct frame_base *base)
{
if (fi->base == NULL)
fi->base = frame_base_find_by_frame (fi);
diff --git a/gdb/frame.h b/gdb/frame.h
index 2c23400..09bf628 100644
--- a/gdb/frame.h
+++ b/gdb/frame.h
@@ -699,6 +699,6 @@ extern struct frame_info *create_new_frame (CORE_ADDR base, CORE_ADDR pc);
/* Return true if the frame base for frame FI is BASE; false
otherwise. */
-extern int frame_base_is (struct frame_info *fi, struct frame_base *base);
+extern int frame_base_is (struct frame_info *fi, const struct frame_base *base);
#endif /* !defined (FRAME_H) */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [archer-tromey-call-frame-cfa] [patch] Fix compilation [resent]
2009-07-29 19:18 ` [archer-tromey-call-frame-cfa] [patch] Fix compilation [resent] Jan Kratochvil
@ 2009-07-29 19:23 ` Tom Tromey
2009-07-29 19:44 ` Jan Kratochvil
0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2009-07-29 19:23 UTC (permalink / raw)
To: Jan Kratochvil; +Cc: archer
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> dwarf2-frame.c: In function ‘dwarf2_frame_cfa’:
Jan> dwarf2-frame.c:1257: error: passing argument 2 of ‘frame_base_is’ discards qualifiers from pointer target type
Jan> frame.h:702: note: expected ‘struct frame_base *’ but argument is of type ‘const struct frame_base *’
Jan> Fedora 11 gcc-4.4.0-4.x86_64
Jan> more curious it did not happen to you. OK to check-in?
Weird, I don't remember seeing that, and I'm sure I would have fixed it
if I had.
Yes, this is fine, please check it in. Thanks.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [archer-tromey-call-frame-cfa] [patch] Fix compilation [resent]
2009-07-29 19:23 ` Tom Tromey
@ 2009-07-29 19:44 ` Jan Kratochvil
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kratochvil @ 2009-07-29 19:44 UTC (permalink / raw)
To: Tom Tromey; +Cc: archer
On Wed, 29 Jul 2009 21:23:32 +0200, Tom Tromey wrote:
> Yes, this is fine, please check it in. Thanks.
Checked-in: e1849a4a9801313f99fa3faee8a88267651d6217
(+Updated from FSF GDB HEAD.)
Thanks,
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-29 19:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-29 19:17 [archer-tromey-call-frame-cfa] [patch] Fix compilation Jan Kratochvil
2009-07-29 19:18 ` [archer-tromey-call-frame-cfa] [patch] Fix compilation [resent] Jan Kratochvil
2009-07-29 19:23 ` Tom Tromey
2009-07-29 19:44 ` Jan Kratochvil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).