From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: archer@sourceware.org
Subject: Re: [delayed-symfile] [commit] Fix objfile_relocate
Date: Tue, 08 Dec 2009 19:10:00 -0000 [thread overview]
Message-ID: <20091208191043.GA7466@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <m3y6lead1q.fsf@fleche.redhat.com>
On Mon, 07 Dec 2009 18:50:41 +0100, Tom Tromey wrote:
> Jan> + /* Alread QUICK_ADDRMAP tiself assumes all sections have the same offset. */
>
> Two typos, "Already" and "itself".
>
> Also, AFAICT gcc only emits text ranges in .debug_aranges.
Later found at least dwarf2read.c already commonly assumes SECT_OFF_TEXT is
applicable to any types (/data/bss) of inferior objects.
Thanks,
Jan
aaeaa5944753c471599839b077635e4b3717d870
From: Jan Kratochvil <jkratoch@host1.dyn.jankratochvil.net>
Date: Tue, 8 Dec 2009 20:07:13 +0100
Subject: [PATCH] Drop <quick_addrmap> comment.
* objfiles.c (objfile_relocate) <quick_addrmap>: Drop the comment.
---
gdb/objfiles.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/gdb/objfiles.c b/gdb/objfiles.c
index 0f75ebd..2cd1001 100644
--- a/gdb/objfiles.c
+++ b/gdb/objfiles.c
@@ -633,7 +633,6 @@ objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets)
}
}
- /* Alread QUICK_ADDRMAP tiself assumes all sections have the same offset. */
if (objfile->quick_addrmap)
addrmap_relocate (objfile->quick_addrmap,
ANOFFSET (delta, SECT_OFF_TEXT (objfile)));
--
1.6.5.2
prev parent reply other threads:[~2009-12-08 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 21:06 Jan Kratochvil
2009-12-07 17:50 ` Tom Tromey
2009-12-08 19:10 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208191043.GA7466@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=archer@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).