Re: find-debuginfo.sh change for gdb index

[Roland McGrath <roland@redhat.com>]

> I don't know what other changes may be needed to ensure that the proper
> gdb is in the buildroots when this script is run.  Also, the proper gdb
> is not actually available yet; cleaning up that patch series is my next
> task.

The rpm-build subpackage will need "Requires: gdb >= V-R".  Obviously, the
patch can't go in anywhere until that gdb is built in dist-rawhide.

> I think this should probably be local to Fedora, but if you think it
> should go into upstream RPM, I am happy to try that.

It's certainly Fedora-specific and only for Fedora 14.

> +  gdb --batch-silent -ex "file $f" -ex "maintenance save-gnu-index $d" > /dev/null 2>&1

I don't quite understand what file this writes to.
Is it implicitly "<symfile name>.index" in the argument directory?

IMHO, the file name should have "gdb" in the name.  
This is really not any very generic sort of index for the information.

>    if [ -n "$id" ]; then
>      make_id_link "$id" "$dn/$(basename $f)"
>      make_id_link "$id" "/usr/lib/debug$dn/$bn" .debug
> +
> +    if [ -f "${debugfn}.index" ]; then
> +      make_id_link "$id" "/usr/lib/debug$dn/$bn" .debug
> +    fi

What's this for?  It just repeats the work of making and recording the
build-id symlink to the .debug file.  Unless you're being quite subtle
somehow I've missed, this doesn't do anything with the index file.
Do you mean something like:

	make_id_link "$id" "/usr/lib/debug$dn/$bn" .index

?  That gets you a /usr/lib/debug/.build-id/xx/yyy.index symlink
to ../../usr/bin/foobar.index for example.


Thanks,
Roland