public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Project Archer <archer@sourceware.org>, pmatilai@redhat.com
Subject: Re: find-debuginfo.sh change for gdb index
Date: Wed, 30 Jun 2010 17:35:00 -0000	[thread overview]
Message-ID: <m3r5joscvs.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100629232147.C019548255@magilla.sf.frob.com> (Roland McGrath's message of "Tue, 29 Jun 2010 16:21:47 -0700 (PDT)")

>>>>> "Roland" == Roland McGrath <roland@redhat.com> writes:

Roland> I don't quite understand what file this writes to.
Roland> Is it implicitly "<symfile name>.index" in the argument directory?

Yes.

Roland> IMHO, the file name should have "gdb" in the name.  
Roland> This is really not any very generic sort of index for the information.

Ok.  What do you think of just ".gdb as the suffix?

>> +    if [ -f "${debugfn}.index" ]; then
>> +      make_id_link "$id" "/usr/lib/debug$dn/$bn" .debug
>> +    fi

Roland> What's this for?  It just repeats the work of making and recording the
Roland> build-id symlink to the .debug file.  Unless you're being quite subtle
Roland> somehow I've missed, this doesn't do anything with the index file.
Roland> Do you mean something like:

Roland> 	make_id_link "$id" "/usr/lib/debug$dn/$bn" .index

Roland> ?  That gets you a /usr/lib/debug/.build-id/xx/yyy.index symlink
Roland> to ../../usr/bin/foobar.index for example.

Yeah, oops.  I will fix this.

Tom

  reply	other threads:[~2010-06-30 17:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 22:32 Tom Tromey
2010-06-29 23:21 ` Roland McGrath
2010-06-30 17:35   ` Tom Tromey [this message]
2010-06-30 18:14     ` Roland McGrath
2010-06-30 18:23       ` Tom Tromey
2010-06-30 20:42         ` Tom Tromey
2010-06-30 20:44           ` Roland McGrath
2010-06-30 21:25             ` Tom Tromey
2010-06-30 21:58               ` Tom Tromey
2010-06-30 22:00                 ` Tom Tromey
2010-06-30 22:14               ` Roland McGrath
2010-07-02 19:55                 ` Tom Tromey
2010-07-05  9:36                   ` Panu Matilainen
2010-07-05  9:48                     ` Jan Kratochvil
2010-07-05 10:39                       ` Panu Matilainen
2010-07-06 18:35                     ` Tom Tromey
2010-07-06 19:14                       ` Roland McGrath
2010-07-06 19:41                         ` Tom Tromey
2010-07-06 20:28                           ` Roland McGrath
2010-07-08 15:56                         ` Tom Tromey
2010-07-08 20:36                           ` Tom Tromey
2010-07-08 22:53                           ` Roland McGrath
2010-07-09  5:07                             ` Panu Matilainen
2010-07-09 17:48                               ` Tom Tromey
2010-07-30 21:36                                 ` Tom Tromey
2010-07-30 23:07                                   ` Roland McGrath
2010-07-30 23:09                                   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r5joscvs.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=archer@sourceware.org \
    --cc=pmatilai@redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).