From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
archer@sourceware.org
Subject: Re: PATCH? gdb remote.c: readchar() should pop_target() if SERIAL_ERROR?
Date: Fri, 02 Jul 2010 01:29:00 -0000 [thread overview]
Message-ID: <20100702012933.E576C4C33C@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Friday, 2 July 2010 03:13:02 +0200 <20100702011302.GA24599@redhat.com>
I don't know that part of the code at all well either. But your fix looks
clearly correct. Both code paths leave in the same way (perror_with_name
is a wrapper around error), so their cleanup calls should match.
Thanks,
Roland
next prev parent reply other threads:[~2010-07-02 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 1:14 Oleg Nesterov
2010-07-02 1:29 ` Roland McGrath [this message]
2010-07-02 20:10 ` Tom Tromey
2010-07-30 21:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100702012933.E576C4C33C@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=archer@sourceware.org \
--cc=fche@redhat.com \
--cc=oleg@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).