From: Oleg Nesterov <oleg@redhat.com>
To: archer@sourceware.org, utrace-devel@redhat.com
Subject: Re: gdbstub initial code, v3
Date: Thu, 12 Aug 2010 02:40:00 -0000 [thread overview]
Message-ID: <20100812023750.GA17011@redhat.com> (raw)
In-Reply-To: <20100812011113.GA13212@redhat.com>
On 08/12, Oleg Nesterov wrote:
>
> > I will investigate tomorrow, but I am almost sure gdb is
> > wrong.
>
> Yes, this seems to be true... Tomorrow.
Can't sleep because of this problem ;)
So, the patch below fixes the problem, and gdb + /proc/ugdb seems
to work.
Indeed, gdb sees that this fd is not pipe/tcp and uses the "hardwire"
serial_ops, but hardwire_readchar() doesn't play well with select().
Please teach gdb to use poll/select ?
Oleg.
--- gdb-7.1/gdb/ser-unix.c
+++ gdb-7.1/gdb/ser-unix.c
@@ -452,7 +452,7 @@ hardwire_raw (struct serial *scb)
static int
wait_for (struct serial *scb, int timeout)
{
-#ifdef HAVE_SGTTY
+#if 1
while (1)
{
struct timeval tv;
@@ -474,13 +474,14 @@ wait_for (struct serial *scb, int timeou
else
numfds = gdb_select (scb->fd + 1, &readfds, 0, 0, 0);
- if (numfds <= 0)
+ if (numfds <= 0) {
if (numfds == 0)
return SERIAL_TIMEOUT;
else if (errno == EINTR)
continue;
else
return SERIAL_ERROR; /* Got an error from select or poll */
+ }
return 0;
}
next prev parent reply other threads:[~2010-08-12 2:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 0:01 Oleg Nesterov
2010-08-12 1:14 ` Oleg Nesterov
2010-08-12 2:40 ` Oleg Nesterov [this message]
2010-08-12 4:37 ` Tom Tromey
2010-08-12 23:55 ` problems with v3 (Was: gdbstub initial code, v3) Oleg Nesterov
2010-08-13 1:45 ` problems with v3 Tom Tromey
2010-08-13 1:59 ` Roland McGrath
2010-08-13 4:37 ` Tom Tromey
2010-08-13 8:30 ` Roland McGrath
2010-08-13 16:31 ` Tom Tromey
2010-08-13 21:15 ` Oleg Nesterov
2010-08-13 21:18 ` Tom Tromey
2010-08-13 14:08 ` Daniel Jacobowitz
2010-08-13 20:56 ` problems with v3 (Was: gdbstub initial code, v3) Oleg Nesterov
2010-08-13 21:31 ` Roland McGrath
2010-08-13 1:02 ` gdbstub initial code, v3 Roland McGrath
2010-08-12 14:52 ` Kevin Buettner
2010-08-13 0:53 ` Roland McGrath
2010-08-13 3:31 ` Kevin Buettner
2010-08-12 15:06 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100812023750.GA17011@redhat.com \
--to=oleg@redhat.com \
--cc=archer@sourceware.org \
--cc=utrace-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).