From: Roland McGrath <roland@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
archer@sourceware.org, utrace-devel@redhat.com
Subject: Re: problems with v3
Date: Fri, 13 Aug 2010 08:30:00 -0000 [thread overview]
Message-ID: <20100813082949.93D1E400E3@magilla.sf.frob.com> (raw)
In-Reply-To: Tom Tromey's message of Thursday, 12 August 2010 22:37:18 -0600 <m3sk2j162p.fsf@fleche.redhat.com>
> I don't know this area well, but considering that ser-unix.c is just
> chock full of tty-related goo, I think it is probably important for
> something. My impression is that this API is not just used for target
> communication but also for manipulating gdb's own terminal.
Ah, I see.
> I've appended the patch I came up with. I have not tried it at all, but
> it should all be pretty obvious.
Yeah, that seems like it should be reasonable, i.e. more or less like what
I'd figured it would do if it didn't have all these different backends.
However, I think the test you probably want is !S_ISCHR.
I believe that /proc/ugdb as is stats as S_ISREG, not S_ISFIFO.
Actually, better yet, just make it !isatty (fd).
Another pseudodevice that also behaves more like a socket than
like a tty might be S_ISCHR, but only a tty isatty.
Thanks,
Roland
next prev parent reply other threads:[~2010-08-13 8:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 0:01 gdbstub initial code, v3 Oleg Nesterov
2010-08-12 1:14 ` Oleg Nesterov
2010-08-12 2:40 ` Oleg Nesterov
2010-08-12 4:37 ` Tom Tromey
2010-08-12 23:55 ` problems with v3 (Was: gdbstub initial code, v3) Oleg Nesterov
2010-08-13 1:45 ` problems with v3 Tom Tromey
2010-08-13 1:59 ` Roland McGrath
2010-08-13 4:37 ` Tom Tromey
2010-08-13 8:30 ` Roland McGrath [this message]
2010-08-13 16:31 ` Tom Tromey
2010-08-13 21:15 ` Oleg Nesterov
2010-08-13 21:18 ` Tom Tromey
2010-08-13 14:08 ` Daniel Jacobowitz
2010-08-13 20:56 ` problems with v3 (Was: gdbstub initial code, v3) Oleg Nesterov
2010-08-13 21:31 ` Roland McGrath
2010-08-13 1:02 ` gdbstub initial code, v3 Roland McGrath
2010-08-12 14:52 ` Kevin Buettner
2010-08-13 0:53 ` Roland McGrath
2010-08-13 3:31 ` Kevin Buettner
2010-08-12 15:06 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100813082949.93D1E400E3@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=archer@sourceware.org \
--cc=oleg@redhat.com \
--cc=tromey@redhat.com \
--cc=utrace-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).