From: Keith Seitz <keiths@redhat.com>
To: jan.kratochvil@redhat.com
Cc: archer@sourceware.org
Subject: Re: [expr] [patch] Fix AAA::ALPHA regression after FSF GDB merge
Date: Wed, 27 Jan 2010 19:15:00 -0000 [thread overview]
Message-ID: <4B6090D8.3030801@redhat.com> (raw)
In-Reply-To: <4B608BCB.7070001@redhat.com>
On 01/27/2010 10:54 AM, Sami Wagiaalla wrote:
> On 01/27/2010 01:33 PM, Jan Kratochvil wrote:
>> The patch below in fact exactly reverts a change of [expr-cumulative].
>>
>
> A change by Keith ? If so then maybe he has some concerns. Probably that
> linkage name is being used during lookup not that it is being set here.
>
>> OK to check-in?
>>
>> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
>>
>
> Okay by me if keith has no objections
I think that the change that I made (from May 2009) from
dwarf2_full_name was probably a workaround to a problem that has since
been solved.
Since your patch causes no regressions in realcpp.exp, I would say that
your patch should be committed. Thanks!
Keith
next prev parent reply other threads:[~2010-01-27 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 18:33 Jan Kratochvil
2010-01-27 18:50 ` Sami Wagiaalla
2010-01-27 19:15 ` Keith Seitz [this message]
2010-01-27 20:26 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6090D8.3030801@redhat.com \
--to=keiths@redhat.com \
--cc=archer@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).