From: sami wagiaalla <swagiaal@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: Re: [[inferior events] partial cleanup for copy_py_list
Date: Wed, 15 Dec 2010 15:57:00 -0000 [thread overview]
Message-ID: <4D08E57D.4000200@redhat.com> (raw)
In-Reply-To: <m3ei9kowv9.fsf@fleche.redhat.com>
On 12/14/2010 04:41 PM, Tom Tromey wrote:
> This fixes some issues in copy_py_list, but not all.
>
> The patch changes it to check PyList_Append.
>
> I think it should probably use an iterator to go through the list.
> Otherwise it is susceptible to a bug where another thread changes the
> list while we are iterating over it.
>
Hmm I did not know we had the option of using a safe iterator. If we do
then that eliminates the need for copy_py_list in the first place;
copy_py_list is used to make the call back of listeners safe against one
listener editing the list during the iteration by removing an element.
> Still, ok to push in this form?
>
Yes. And thanks for the cleanups.
Sami
next prev parent reply other threads:[~2010-12-15 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 21:41 Tom Tromey
2010-12-15 15:57 ` sami wagiaalla [this message]
2010-12-15 16:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08E57D.4000200@redhat.com \
--to=swagiaal@redhat.com \
--cc=archer@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).