From: Tom Tromey <tromey@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: Re: [rfc] patch for pr8880
Date: Mon, 08 Feb 2010 17:30:00 -0000 [thread overview]
Message-ID: <m33a1b8wkn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B703D65.302@redhat.com> (Sami Wagiaalla's message of "Mon, 08 Feb 2010 11:35:49 -0500")
>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:
Sami> This was a long chase but an easy fix.
Sami> Thoughts ?
Lots of formatting nits.
Also I have a few more substantive comments.
Sami> +struct value *
Sami> +value_at_value (struct value *value)
Sami> +{
Sami> + return value_at(TYPE_TARGET_TYPE (value_type(value)),
Sami> + value_as_address(value));
Why not just use value_ind?
Sami> @@ -2104,6 +2111,9 @@ value_struct_elt (struct value **argp, struct value **args,
Modifying value_struct_elt seems dangerous. This is called from many
places in the code, including some which don't expect ADL to be used --
e.g., Java, Ada.
Can this be done by the caller somehow instead?
Or perhaps some refactoring is needed.
Also, ADL should only be done for unqualified names.
It isn't clear to me that this change satisfies that requirement.
Tom
next prev parent reply other threads:[~2010-02-08 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 16:35 Sami Wagiaalla
2010-02-08 17:30 ` Tom Tromey [this message]
2010-02-09 19:23 ` Sami Wagiaalla
2010-02-09 23:35 ` Tom Tromey
2010-02-11 21:00 ` Tom Tromey
2010-02-12 15:44 ` Sami Wagiaalla
2010-02-18 19:45 ` Sami Wagiaalla
2010-02-19 23:23 ` Tom Tromey
2010-02-22 16:37 ` Sami Wagiaalla
2010-02-23 22:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33a1b8wkn.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archer@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).