[python] trivial regression by new has_more="0"

[python] trivial regression by new has_more="0"

[Jan Kratochvil]

Hi Tom,

3 leftover cases causing a regression.

Thanks,
Jan


Expecting: ^(-var-update linteger[
]+)?(\^done,changelist=\[{name="linteger",in_scope="invalid"}\][
]+[(]gdb[)] 
[ ]*)
-var-update linteger^M 
^done,changelist=[{name="linteger",in_scope="invalid",has_more="0"}]
(gdb) 
FAIL: gdb.mi/mi-var-invalidate.exp: linteger not anymore in scope due to binary changes

Expecting: ^(-var-update linteger[
]+)?(\^done,changelist=\[{name="linteger",in_scope="invalid"}\][
]+[(]gdb[)] 
[ ]*)
-var-update linteger
^done,changelist=[{name="linteger",in_scope="invalid",has_more="0"}]
(gdb) 
FAIL: gdb.mi/mi-var-invalidate.exp: linteger not valid anymore due to binary changes

Expecting: ^(-var-update global_simple[
]+)?(\^done,changelist=\[{name="global_simple",in_scope="invalid"}\][
]+[(]gdb[)] 
[ ]*)
-var-update global_simple
^done,changelist=[{name="global_simple",in_scope="invalid",has_more="0"}]
(gdb) 
FAIL: gdb.mi/mi-var-invalidate.exp: global_simple not anymore in scope due to binary changes


On Mon, 31 Aug 2009 17:13:57 +0200, tromey@sourceware.org wrote:
> The branch, archer-tromey-python has been updated
>        via  cb5408c12b9747fee95f09ae207acaf4751e7398 (commit)
>       from  ad40d573de25e2914c5103442856248021660940 (commit)
> 
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email.
> 
> - Log -----------------------------------------------------------------
> commit cb5408c12b9747fee95f09ae207acaf4751e7398
> Author: Tom Tromey <tromey@redhat.com>
> Date:   Mon Aug 31 09:13:33 2009 -0600
> 
>     gdb
>     	* varobj.c (varobj_has_more): Also check for to==-1.
>     	(varobj_update): Call update_dynamic_varobj_children if children
>     	have not been requested.
>     	* mi/mi-cmd-var.c (varobj_update_one): Always emit has_more.
>     gdb/testsuite
>     	* lib/mi-support.exp (mi_create_varobj): Expect has_more.
>     	(mi_varobj_update): Likewise.
>     	(mi_varobj_update_with_type_change): Likewise.
>     	* gdb.python/python-prettyprint.c (main): Add another call to
>     	add_item.
>     	* gdb.python/python-mi.exp: Add test for transition from no
>     	children to children.
>     	* gdb.mi/mi2-var-cmd.exp: Update.
>     	* gdb.mi/mi2-var-child.exp: Update.
>     	* gdb.mi/mi2-var-block.exp: Update.
>     	* gdb.mi/mi-var-cmd.exp: Update.
>     	* gdb.mi/mi-var-child.exp: Update.
>     	* gdb.mi/mi-var-block.exp: Update.

Re: [python] trivial regression by new has_more="0"

[Tom Tromey]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> 3 leftover cases causing a regression.

Sorry about that.  I don't know how I missed these, because I ran this
through the regression tester to find the spots to update in the first
place.

Oh well.  Here's the fix.

Tom

2009-09-01  Tom Tromey  <tromey@redhat.com>

	* gdb.mi/mi-var-invalidate.exp: Update.

diff --git a/gdb/testsuite/gdb.mi/mi-var-invalidate.exp b/gdb/testsuite/gdb.mi/mi-var-invalidate.exp
index 05d46fa..4b95674 100644
--- a/gdb/testsuite/gdb.mi/mi-var-invalidate.exp
+++ b/gdb/testsuite/gdb.mi/mi-var-invalidate.exp
@@ -72,7 +72,7 @@ mi_runto main
 
 # Check local variable is "invalid".
 mi_gdb_test "-var-update linteger" \
-	"\\^done,changelist=\\\[\{name=\"linteger\",in_scope=\"invalid\"\}\\\]" \
+	"\\^done,changelist=\\\[\{name=\"linteger\",in_scope=\"invalid\",has_more=\"0\"\}\\\]" \
 	"linteger not anymore in scope due to binary changes"
 
 mi_gdb_test "-var-info-type linteger" \
@@ -97,7 +97,7 @@ mi_delete_breakpoints
 mi_gdb_load ${binfile2}
 # Check local variable are "invalid"
 mi_gdb_test "-var-update linteger" \
-	"\\^done,changelist=\\\[\{name=\"linteger\",in_scope=\"invalid\"\}\\\]" \
+	"\\^done,changelist=\\\[\{name=\"linteger\",in_scope=\"invalid\",has_more=\"0\"\}\\\]" \
 	"linteger not valid anymore due to binary changes"
 
 mi_gdb_test "-var-info-type linteger" \
@@ -106,7 +106,7 @@ mi_gdb_test "-var-info-type linteger" \
 
 # Check global variable are still correct.
 mi_gdb_test "-var-update global_simple" \
-	"\\^done,changelist=\\\[\{name=\"global_simple\",in_scope=\"invalid\"\}\\\]" \
+	"\\^done,changelist=\\\[\{name=\"global_simple\",in_scope=\"invalid\",has_more=\"0\"\}\\\]" \
 	"global_simple not anymore in scope due to binary changes"
 
 mi_gdb_test "-var-info-type global_simple" \