language setting issue

language setting issue

[sami wagiaalla]

For the most part doing this:

if (current_language->la_language == language_cplus)

works fine, but there is a scenario invoked by cp-relocate.exp which 
looks something like this:

./gdb ./testsuite/gdb.cp/cp-relocate.o -ex 'print func<1>(int)' -ex 'q'

In this scenario if we check current_language->la_language it will be 
set to language_c. The problem is that current_language is set by 
checking the extension of the file of the symbol main which in this case 
does not exist.

To solve this we could just pick an arbitrary objfile and check the 
language. This works of we can assume that all files have the same 
language. Otherwise we would have to set the language a per block bases.

Thoughts ?

Sami

Re: language setting issue

[Roland McGrath]

IMHO, any checks for language should be specific to the CU.  You can link
many languages together.  But I don't know what the method for choosing
what to call "the current CU" should be.


Thanks,
Roland

Re: language setting issue

[Jan Kratochvil]

On Wed, 14 Jul 2010 20:51:53 +0200, sami wagiaalla wrote:
> ./gdb ./testsuite/gdb.cp/cp-relocate.o -ex 'print func<1>(int)' -ex 'q'
> 
> In this scenario if we check current_language->la_language it will
> be set to language_c.

> The problem is that current_language is set by checking the extension of the
> file of the symbol main which in this case does not exist.

It is such only before starting the inferior.  Normally select_frame() always
sets current_language according to the frame chosen right now.

Also in some cases language is passed along structures (such as struct
breakpoint) and functions.


> To solve this we could just pick an arbitrary objfile and check the
> language. This works of we can assume that all files have the same
> language. Otherwise we would have to set the language a per block
> bases.

IMO this problem is only for object files which is mostly just a problem for
hackers.  And for gdb testsuite.  But I agree some better autodetection would
be nice.  But only for the case of single objfile (and possibly single CU) to
make the code simple IMO as it gets never used otherwise anyway.


Regards,
Jan

Re: language setting issue

[Tom Tromey]

Sami> ./gdb ./testsuite/gdb.cp/cp-relocate.o -ex 'print func<1>(int)' -ex 'q'

I think it is fine to require a 'set lang c++' in a case like this.
"func<1>" is not valid C.

I am curiousq to know what other user-visible changes you are planning to
make.

Tom