From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: Re: [patch] Fix python/10805
Date: Fri, 30 Oct 2009 22:18:00 -0000 [thread overview]
Message-ID: <m38weso793.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4ADDBEFF.4080805@redhat.com> (Phil Muldoon's message of "Tue, 20 Oct 2009 14:45:35 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> This patch fixes python/10805. When fields were being constructed, the
Phil> convert_fields function was not checking if the type was a class
Phil> before determining if it was a base class. Added a check to gate this
Phil> behaviour.
Looks good, thanks.
Phil> Additionally, I started a testsuite for Python types. This suite only
Phil> tests for this regression, but it can be expanded later, in separate
Phil> efforts.
Awesome.
The is_base_class thing isn't upstream.
It would be good to submit all this sometime.
Tom
next prev parent reply other threads:[~2009-10-30 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 13:45 Phil Muldoon
2009-10-30 22:18 ` Tom Tromey [this message]
2009-11-02 13:48 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38weso793.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archer@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).