public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] RISC-V: Remove "b" operand type from disassembler
@ 2022-09-22  7:05 Tsukasa OI
  0 siblings, 0 replies; only message in thread
From: Tsukasa OI @ 2022-09-22  7:05 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0383bce6502271455804daa533c9d141e7c3fc98

commit 0383bce6502271455804daa533c9d141e7c3fc98
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date:   Sun Aug 7 15:03:28 2022 +0900

    RISC-V: Remove "b" operand type from disassembler
    
    There are a few operand types not used by any RISC-V instructions.
    
    -   Cx
    -   Vf
    -   Ve
    -   [
    -   ]
    -   b
    
    But most of them has a reasoning to keep them:
    
    -   Cx     : Same as "Ct" except it has a constraint to have rd == rs2
                 (similar to "Cw").  Although it hasn't used, its role is clear
                 enough to implement a new instruction with this operand type.
    -   Vf, Ve : Used by vector AMO instructions (not ratified and real
                 instructions are not upstreamed yet).
    -   [, ]   : Unused tokenization symbols.  Reserving them is not harmful
                 and a vendor may use this symbol for special purposes.
    
    ... except "b".  I could not have found any reference to this operand type
    except it works like the "s" operand type.  Historically, it seems... it's
    just unused from the beginning.  Its role is not clear either.
    
    On such cases, we should vacate this room for the new operand type with
    much clearer roles.
    
    opcodes/ChangeLog:
    
            * riscv-dis.c (print_insn_args): Remove 'b' operand type.

Diff:
---
 opcodes/riscv-dis.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
index 7ae6e709290..99cebf37d9e 100644
--- a/opcodes/riscv-dis.c
+++ b/opcodes/riscv-dis.c
@@ -403,7 +403,6 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info
 	    print (info->stream, dis_style_immediate, "0");
 	  break;
 
-	case 'b':
 	case 's':
 	  if ((l & MASK_JALR) == MATCH_JALR)
 	    maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), 0);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-22  7:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22  7:05 [binutils-gdb] RISC-V: Remove "b" operand type from disassembler Tsukasa OI

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).