[binutils-gdb] Re: bfd_cleanup for object_p

[binutils-gdb] Re: bfd_cleanup for object_p

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=31f4ff5731d0e6a0715e1af81e8c5fc5b71d2df6

commit 31f4ff5731d0e6a0715e1af81e8c5fc5b71d2df6
Author: Alan Modra <amodra@gmail.com>
Date:   Fri Sep 23 22:20:17 2022 +0930

    Re: bfd_cleanup for object_p
    
    Bits still missing from commit cb001c0d283d.
    
            * aoutx.h (aout_@var{size}_some_aout_object_p): Correct synopsis.
            * i386lynx.c (lynx_core_file_p): Correct return type.
            * ptrace-core.c (ptrace_unix_core_file_p): Likewise.

Diff:
---
 bfd/aoutx.h       | 4 ++--
 bfd/i386lynx.c    | 2 +-
 bfd/ptrace-core.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/bfd/aoutx.h b/bfd/aoutx.h
index e9b5188e8e7..4aed23426ca 100644
--- a/bfd/aoutx.h
+++ b/bfd/aoutx.h
@@ -451,10 +451,10 @@ FUNCTION
 	aout_@var{size}_some_aout_object_p
 
 SYNOPSIS
-	const bfd_target *aout_@var{size}_some_aout_object_p
+	bfd_cleanup aout_@var{size}_some_aout_object_p
 	 (bfd *abfd,
 	  struct internal_exec *execp,
-	  const bfd_target *(*callback_to_real_object_p) (bfd *));
+	  bfd_cleanup (*callback_to_real_object_p) (bfd *));
 
 DESCRIPTION
 	Some a.out variant thinks that the file open in @var{abfd}
diff --git a/bfd/i386lynx.c b/bfd/i386lynx.c
index 840be8fd36d..5df3d19ffe0 100644
--- a/bfd/i386lynx.c
+++ b/bfd/i386lynx.c
@@ -87,7 +87,7 @@
 char *lynx_core_file_failing_command ();
 int lynx_core_file_failing_signal ();
 bool lynx_core_file_matches_executable_p ();
-const bfd_target *lynx_core_file_p ();
+bfd_cleanup lynx_core_file_p ();
 
 #define	MY_core_file_failing_command lynx_core_file_failing_command
 #define	MY_core_file_failing_signal lynx_core_file_failing_signal
diff --git a/bfd/ptrace-core.c b/bfd/ptrace-core.c
index c4afffbfb95..cf39ff42a6e 100644
--- a/bfd/ptrace-core.c
+++ b/bfd/ptrace-core.c
@@ -48,7 +48,7 @@ struct trad_core_struct
 
 /* forward declarations */
 
-const bfd_target *ptrace_unix_core_file_p (bfd *abfd);
+bfd_cleanup ptrace_unix_core_file_p (bfd *abfd);
 char * ptrace_unix_core_file_failing_command (bfd *abfd);
 int ptrace_unix_core_file_failing_signal (bfd *abfd);
 #define ptrace_unix_core_file_matches_executable_p generic_core_file_matches_executable_p