public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] binutils/testsuite: skip gentestdlls related tests if missing
@ 2022-09-26 15:23 =?unknown-8bit?q?Cl=E9ment_Chigot_=3Chelflym=40sourceware=2Eorg=3E?=
  0 siblings, 0 replies; only message in thread
From: =?unknown-8bit?q?Cl=E9ment_Chigot_=3Chelflym=40sourceware=2Eorg=3E?= @ 2022-09-26 15:23 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e9d92351722884fda8914021b25e5d5a6cc1a181

commit e9d92351722884fda8914021b25e5d5a6cc1a181
Author: Clément Chigot <chigot@adacore.com>
Date:   Fri Sep 16 10:50:34 2022 +0200

    binutils/testsuite: skip gentestdlls related tests if missing
    
    When launching the testsuite through runtest outside the build tree,
    gentestdlls might not be available, this binary being created by make
    check.
    Simply untested the related tests instead of crashing.
    
    binutils/ChangeLog:
    
            * testsuite/binutils-all/objdump.exp: Skip dotnet tests if
            gentestdlls is not available.

Diff:
---
 binutils/testsuite/binutils-all/objdump.exp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index fb099425e34..436fc46d1a8 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -787,6 +787,12 @@ proc test_objdump_dotnet_assemblies {} {
 
     set test "dotnet-assemblies"
 
+    # If gentestdlls isn't available, skip instead of crashing below.
+    if ![file exists $base_dir/testsuite/gentestdlls] {
+	untested $test
+	return
+    }
+
     set got [binutils_run "$base_dir/testsuite/gentestdlls" "tmpdir pei-i386 pei-x86-64"]
     set want "wrote linux-pei-x86-64.dll"
     # The test program is hardcoded to generate valid dlls on any target

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-26 15:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 15:23 [binutils-gdb] binutils/testsuite: skip gentestdlls related tests if missing =?unknown-8bit?q?Cl=E9ment_Chigot_=3Chelflym=40sourceware=2Eorg=3E?=

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).