* [binutils-gdb] libsframe: use return type of bool for predicate functions
@ 2023-04-19 21:59 Indu Bhagat
0 siblings, 0 replies; only message in thread
From: Indu Bhagat @ 2023-04-19 21:59 UTC (permalink / raw)
To: bfd-cvs, gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=26be6015b750e7e2b40718b09c6195e8986be461
commit 26be6015b750e7e2b40718b09c6195e8986be461
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date: Wed Apr 19 14:12:12 2023 -0700
libsframe: use return type of bool for predicate functions
libsframe/
* sframe.c (sframe_header_sanity_check_p): Change return type to
bool.
(sframe_fre_sanity_check_p): Likewise.
Diff:
---
libsframe/sframe.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index ea3169ba7aa..907214a8a89 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -201,7 +201,7 @@ flip_fde (sframe_func_desc_entry *fdep)
/* Check if SFrame header has valid data. */
-static int
+static bool
sframe_header_sanity_check_p (sframe_header *hp)
{
unsigned char all_flags = SFRAME_F_FDE_SORTED | SFRAME_F_FRAME_POINTER;
@@ -209,13 +209,13 @@ sframe_header_sanity_check_p (sframe_header *hp)
if ((hp->sfh_preamble.sfp_magic != SFRAME_MAGIC)
|| (hp->sfh_preamble.sfp_version != SFRAME_VERSION)
|| ((hp->sfh_preamble.sfp_flags | all_flags) != all_flags))
- return 0;
+ return false;
/* Check offsets are valid. */
if (hp->sfh_fdeoff > hp->sfh_freoff)
- return 0;
+ return false;
- return 1;
+ return true;
}
/* Flip the start address pointed to by FP. */
@@ -284,14 +284,14 @@ sframe_fre_start_addr_size (unsigned int fre_type)
/* Check if the FREP has valid data. */
-static int
+static bool
sframe_fre_sanity_check_p (sframe_frame_row_entry *frep)
{
unsigned int offset_size, offset_cnt;
unsigned int fre_info;
if (frep == NULL)
- return 0;
+ return false;
fre_info = frep->fre_info;
offset_size = sframe_fre_get_offset_size (fre_info);
@@ -299,13 +299,13 @@ sframe_fre_sanity_check_p (sframe_frame_row_entry *frep)
if (offset_size != SFRAME_FRE_OFFSET_1B
&& offset_size != SFRAME_FRE_OFFSET_2B
&& offset_size != SFRAME_FRE_OFFSET_4B)
- return 0;
+ return false;
offset_cnt = sframe_fre_get_offset_count (fre_info);
if (offset_cnt > 3)
- return 0;
+ return false;
- return 1;
+ return true;
}
/* Get FRE_INFO's offset size in bytes. */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-19 21:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-19 21:59 [binutils-gdb] libsframe: use return type of bool for predicate functions Indu Bhagat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).