[binutils-gdb] Revert "x86: work around compiler diagnosing dangling pointer"

[binutils-gdb] Revert "x86: work around compiler diagnosing dangling pointer"

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ea5c591c023544e40bb4967314a47d8e6a1e806d

commit ea5c591c023544e40bb4967314a47d8e6a1e806d
Author: Alan Modra <amodra@gmail.com>
Date:   Mon Apr 24 21:00:00 2023 +0930

    Revert "x86: work around compiler diagnosing dangling pointer"
    
    This reverts commit 983db9932a302f9e2ae1f1d4fd7c3149560bc269.

Diff:
---
 opcodes/i386-dis.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 1fe54289655..01e5ba81723 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -345,12 +345,6 @@ fetch_error (const instr_info *ins)
   const struct dis_private *priv = ins->info->private_data;
   const char *name = NULL;
 
-  /* Our caller has put a pointer to a local variable in info->private_data
-     and it is going to return right after this function has returned.  Some
-     compilers diagnose this as a dangling pointer.  Zap the pointer here to
-     avoid needing to do so on all involved return paths in the caller.  */
-  ins->info->private_data = NULL;
-
   if (ins->codep <= priv->the_buffer)
     return -1;