public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] x86: fix disassembler build after 1a3b4f90bc5f
@ 2023-05-26 10:45 Jan Beulich
  0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2023-05-26 10:45 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=93497bf9ab13a3d2aa06ff329155beca23e323fa

commit 93497bf9ab13a3d2aa06ff329155beca23e323fa
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri May 26 12:44:52 2023 +0200

    x86: fix disassembler build after 1a3b4f90bc5f
    
    In commit 1a3b4f90bc5f ("x86: convert two pointers to (indexing)
    integers") I neglected the fact that compilers may warn about comparing
    ptrdiff_t (signed long) with size_t (unsigned long) values. Since just
    before we've checked that the value is positive, simply add a cast
    (despite my dislike for casts).

Diff:
---
 opcodes/i386-dis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 6f75abf57f3..6161bf72459 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -300,7 +300,7 @@ fetch_code (struct disassemble_info *info, const uint8_t *until)
   if (needed <= 0)
     return true;
 
-  if (priv->fetched + needed <= ARRAY_SIZE (priv->the_buffer))
+  if (priv->fetched + (size_t) needed <= ARRAY_SIZE (priv->the_buffer))
     status = (*info->read_memory_func) (start, fetch_end, needed, info);
   if (status != 0)
     {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-26 10:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 10:45 [binutils-gdb] x86: fix disassembler build after 1a3b4f90bc5f Jan Beulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).