public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Indu Bhagat <ibhagat@sourceware.org>
To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org
Subject: [binutils-gdb] libsframe: fix cosmetic issues and typos
Date: Tue,  6 Jun 2023 17:52:42 +0000 (GMT)	[thread overview]
Message-ID: <20230606175242.465C43858C5F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f4af42724b8c968c355796b561434250aa605458

commit f4af42724b8c968c355796b561434250aa605458
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date:   Tue Jun 6 10:50:07 2023 -0700

    libsframe: fix cosmetic issues and typos
    
    include/
            * sframe-api.h (sframe_decoder_get_num_fidx): Use extern.
    libsframe/
            * sframe-dump.c (dump_sframe_func_with_fres): Fix line length.
            * sframe.c (sframe_frame_row_entry_copy): Likewise.
            (sframe_decode_fre_start_address): Use the intended type uint32_t.

Diff:
---
 include/sframe-api.h    | 2 +-
 libsframe/sframe-dump.c | 5 +++--
 libsframe/sframe.c      | 5 +++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/include/sframe-api.h b/include/sframe-api.h
index 3245bc8ac90..df1f5ccef4c 100644
--- a/include/sframe-api.h
+++ b/include/sframe-api.h
@@ -122,7 +122,7 @@ sframe_decoder_get_abi_arch (sframe_decoder_ctx *dctx);
 
 /* Return the number of function descriptor entries in the SFrame decoder
    DCTX.  */
-unsigned int
+extern unsigned int
 sframe_decoder_get_num_fidx (sframe_decoder_ctx *dctx);
 
 /* Get the fixed FP offset from the decoder context DCTX.  */
diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c
index 77aa87d67a1..6d266392cd7 100644
--- a/libsframe/sframe-dump.c
+++ b/libsframe/sframe-dump.c
@@ -2,7 +2,7 @@
 
    Copyright (C) 2022-2023 Free Software Foundation, Inc.
 
-   his file is part of libsframe.
+   This file is part of libsframe.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -134,7 +134,8 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx,
 
   char temp[100];
 
-  printf ("\n    %-7s%-8s %-10s%-10s%-13s", "STARTPC", fde_type_marker, "CFA", "FP", "RA");
+  printf ("\n    %-7s%-8s %-10s%-10s%-13s",
+	  "STARTPC", fde_type_marker, "CFA", "FP", "RA");
   for (j = 0; j < num_fres; j++)
     {
       sframe_decoder_get_fre (sfd_ctx, funcidx, j, &fre);
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index b05fed97e61..a7615329767 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -667,7 +667,8 @@ sframe_fre_get_ra_mangled_p (sframe_decoder_ctx *dctx ATTRIBUTE_UNUSED,
 }
 
 static int
-sframe_frame_row_entry_copy (sframe_frame_row_entry *dst, sframe_frame_row_entry *src)
+sframe_frame_row_entry_copy (sframe_frame_row_entry *dst,
+			     sframe_frame_row_entry *src)
 {
   int err = 0;
 
@@ -711,7 +712,7 @@ sframe_decode_fre_start_address (const char *fre_buf,
   else if (fre_type == SFRAME_FRE_TYPE_ADDR4)
     {
       uint32_t *uit = (uint32_t *)fre_buf;
-      int32_t tmp = 0;
+      uint32_t tmp = 0;
       memcpy (&tmp, uit, addr_size);
       saddr = (uint32_t)tmp;
     }

                 reply	other threads:[~2023-06-06 17:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230606175242.465C43858C5F@sourceware.org \
    --to=ibhagat@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).