* [binutils-gdb] bfd/elf.c strtab memory leak
@ 2023-06-07 2:02 Alan Modra
0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-06-07 2:02 UTC (permalink / raw)
To: bfd-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c7e6669a5b29240b1e5f6fd2acc987fd75b71044
commit c7e6669a5b29240b1e5f6fd2acc987fd75b71044
Author: Alan Modra <amodra@gmail.com>
Date: Wed Jun 7 09:41:57 2023 +0930
bfd/elf.c strtab memory leak
* elf.c (_bfd_elf_compute_section_file_positions): Free strtab
on set_group_contents failure return path.
Diff:
---
bfd/elf.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/bfd/elf.c b/bfd/elf.c
index 81eb3ef71fa..af2fb04dcbe 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -4254,7 +4254,11 @@ _bfd_elf_compute_section_file_positions (bfd *abfd,
{
bfd_map_over_sections (abfd, bfd_elf_set_group_contents, &failed);
if (failed)
- return false;
+ {
+ if (need_symtab)
+ _bfd_elf_strtab_free (strtab);
+ return false;
+ }
}
shstrtab_hdr = &elf_tdata (abfd)->shstrtab_hdr;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-07 2:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-07 2:02 [binutils-gdb] bfd/elf.c strtab memory leak Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).