[binutils-gdb] Re: _bfd_free_cached_info

[binutils-gdb] Re: _bfd_free_cached_info

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=12f7174bf069f407d5b6f12e926ceabe45e450e1

commit 12f7174bf069f407d5b6f12e926ceabe45e450e1
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Jun 8 10:37:40 2023 +0930

    Re: _bfd_free_cached_info
    
    Oops, another leak caused by not defining the correct macro.
    
            * elf32-mips.c: Define bfd_elf32_bfd_free_cached_info.
            * elfn32-mips.c: Likewise.
            * elf64-mips.c: Define bfd_elf64_bfd_free_cached_info.

Diff:
---
 bfd/elf32-mips.c  | 2 +-
 bfd/elf64-mips.c  | 2 +-
 bfd/elfn32-mips.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/bfd/elf32-mips.c b/bfd/elf32-mips.c
index 27bd98607fe..34ffa67edec 100644
--- a/bfd/elf32-mips.c
+++ b/bfd/elf32-mips.c
@@ -2599,7 +2599,7 @@ static const struct ecoff_debug_swap mips_elf32_ecoff_debug_swap = {
 					_bfd_mips_elf_print_private_bfd_data
 #define bfd_elf32_bfd_relax_section	_bfd_mips_elf_relax_section
 #define bfd_elf32_mkobject		_bfd_mips_elf_mkobject
-#define bfd_elf32_free_cached_info	_bfd_mips_elf_free_cached_info
+#define bfd_elf32_bfd_free_cached_info	_bfd_mips_elf_free_cached_info
 
 /* Support for SGI-ish mips targets.  */
 #define TARGET_LITTLE_SYM		mips_elf32_le_vec
diff --git a/bfd/elf64-mips.c b/bfd/elf64-mips.c
index 1179f622193..0530be1253f 100644
--- a/bfd/elf64-mips.c
+++ b/bfd/elf64-mips.c
@@ -4815,7 +4815,7 @@ const struct elf_size_info mips_elf64_size_info =
 
 #define bfd_elf64_get_dynamic_reloc_upper_bound mips_elf64_get_dynamic_reloc_upper_bound
 #define bfd_elf64_mkobject		_bfd_mips_elf_mkobject
-#define bfd_elf64_free_cached_info	_bfd_mips_elf_free_cached_info
+#define bfd_elf64_bfd_free_cached_info	_bfd_mips_elf_free_cached_info
 
 /* The SGI style (n)64 NewABI.  */
 #define TARGET_LITTLE_SYM		mips_elf64_le_vec
diff --git a/bfd/elfn32-mips.c b/bfd/elfn32-mips.c
index e6aa1673586..3ae11e2f992 100644
--- a/bfd/elfn32-mips.c
+++ b/bfd/elfn32-mips.c
@@ -4197,7 +4197,7 @@ static const struct ecoff_debug_swap mips_elf32_ecoff_debug_swap = {
 #define bfd_elf32_bfd_print_private_bfd_data \
 					_bfd_mips_elf_print_private_bfd_data
 #define bfd_elf32_mkobject		mips_elf_n32_mkobject
-#define bfd_elf32_free_cached_info	_bfd_mips_elf_free_cached_info
+#define bfd_elf32_bfd_free_cached_info	_bfd_mips_elf_free_cached_info
 
 /* Support for SGI-ish mips targets using n32 ABI.  */

[binutils-gdb] Re: _bfd_free_cached_info

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=09d757a5c2f8824ef687b9c6d7ad834f89a3cc17

commit 09d757a5c2f8824ef687b9c6d7ad834f89a3cc17
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Jun 8 10:18:01 2023 +0930

    Re: _bfd_free_cached_info
    
    ELF targets with target-specific free_cache_info functions need to
    call _bfd_elf_free_cached_info, not _bfd_generic_bfd_free_cached_info.
    
            * elf64-ppc.c (ppc64_elf_free_cached_info): Call
            _bfd_elf_free_cached_info.
            * elfnn-aarch64.c (elfNN_aarch64_bfd_free_cached_info): Likewise.

Diff:
---
 bfd/elf64-ppc.c     | 2 +-
 bfd/elfnn-aarch64.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 9c0762a15ef..0e9a7ff96c3 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -18406,7 +18406,7 @@ ppc64_elf_free_cached_info (bfd *abfd)
       if (opd->reloc_count == 0)
 	free (ppc64_elf_section_data (opd)->u.opd.u.contents);
 
-  return _bfd_generic_bfd_free_cached_info (abfd);
+  return _bfd_elf_free_cached_info (abfd);
 }
 
 #include "elf64-target.h"
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index a75cd365a02..4592bd6da27 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -8742,7 +8742,7 @@ elfNN_aarch64_bfd_free_cached_info (bfd *abfd)
     bfd_map_over_sections (abfd,
 			   unrecord_section_via_map_over_sections, NULL);
 
-  return _bfd_generic_bfd_free_cached_info (abfd);
+  return _bfd_elf_free_cached_info (abfd);
 }
 
 /* Create dynamic sections. This is different from the ARM backend in that