public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] x86: fix expansion of %XV
@ 2023-06-21  6:32 Jan Beulich
  0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2023-06-21  6:32 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fffb10b122c58128f604ddabd421db84c99a5eaa

commit fffb10b122c58128f604ddabd421db84c99a5eaa
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Jun 21 08:32:13 2023 +0200

    x86: fix expansion of %XV
    
    Only %LV should continue on to S handling; avoid emitting a stray 'l'
    (typically) in suffix-always mode.

Diff:
---
 opcodes/i386-dis.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 6161bf72459..15a0e1b1080 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -11055,19 +11055,20 @@ putop (instr_info *ins, const char *in_template, int sizeflag)
 		  *ins->obufp++ = ' ';
 		  break;
 		case 'L':
-		  if (!(ins->rex & REX_W))
-		    break;
-		  *ins->obufp++ = 'a';
-		  *ins->obufp++ = 'b';
-		  *ins->obufp++ = 's';
-		  break;
+		  if (ins->rex & REX_W)
+		    {
+		      *ins->obufp++ = 'a';
+		      *ins->obufp++ = 'b';
+		      *ins->obufp++ = 's';
+		    }
+		  goto case_S;
 		default:
 		  abort ();
 		}
 	    }
 	  else
 	    abort ();
-	  goto case_S;
+	  break;
 	case 'W':
 	  if (l == 0)
 	    {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-21  6:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-21  6:32 [binutils-gdb] x86: fix expansion of %XV Jan Beulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).