public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] libsframe: use appropriate data types for args of sframe_encode
@ 2023-06-27 19:42 Indu Bhagat
  0 siblings, 0 replies; only message in thread
From: Indu Bhagat @ 2023-06-27 19:42 UTC (permalink / raw)
  To: bfd-cvs, gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3412dcec612b473adabdff0e5d6004bfc94c938c

commit 3412dcec612b473adabdff0e5d6004bfc94c938c
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date:   Tue Jun 27 11:56:13 2023 -0700

    libsframe: use appropriate data types for args of sframe_encode
    
    include/
            * sframe-api.h (sframe_encode): Use of uint8_t is more
            appropriate.
    libsframe/
            * sframe.c (sframe_encode): Likewise.

Diff:
---
 include/sframe-api.h | 2 +-
 libsframe/sframe.c   | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/sframe-api.h b/include/sframe-api.h
index 46614925c68..9cb2db0edb9 100644
--- a/include/sframe-api.h
+++ b/include/sframe-api.h
@@ -202,7 +202,7 @@ sframe_fre_get_ra_mangled_p (sframe_decoder_ctx *dctx,
 /* Create an encoder context with the given SFrame format version VER, FLAGS
    and ABI information.  Sets errp if failure.  */
 extern sframe_encoder_ctx *
-sframe_encode (unsigned char ver, unsigned char flags, int abi,
+sframe_encode (uint8_t ver, uint8_t flags, uint8_t abi_arch,
 	       int8_t fixed_fp_offset, int8_t fixed_ra_offset, int *errp);
 
 /* Free the encoder context.  */
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index b885e3df5ec..40927f06933 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -1248,10 +1248,11 @@ sframe_encoder_get_funcdesc_at_index (sframe_encoder_ctx *encoder,
 }
 
 /* Create an encoder context with the given SFrame format version VER, FLAGS
-   and ABI information.  Sets errp if failure.  */
+   and ABI information.  Uses the ABI specific FIXED_FP_OFFSET and
+   FIXED_RA_OFFSET values as provided.  Sets errp if failure.  */
 
 sframe_encoder_ctx *
-sframe_encode (unsigned char ver, unsigned char flags, int abi_arch,
+sframe_encode (uint8_t ver, uint8_t flags, uint8_t abi_arch,
 	       int8_t fixed_fp_offset, int8_t fixed_ra_offset, int *errp)
 {
   sframe_header *hp;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-27 19:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-27 19:42 [binutils-gdb] libsframe: use appropriate data types for args of sframe_encode Indu Bhagat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).