* [binutils-gdb] LoongArch: gas: Fix shared builds
@ 2023-07-03 1:04 liu & zhensong
0 siblings, 0 replies; only message in thread
From: liu & zhensong @ 2023-07-03 1:04 UTC (permalink / raw)
To: bfd-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4bf2114b634413e224c990593455168b873519d9
commit 4bf2114b634413e224c990593455168b873519d9
Author: WANG Xuerui <git@xen0n.name>
Date: Sun Jul 2 18:14:22 2023 +0800
LoongArch: gas: Fix shared builds
Formerly an include of libbfd.h was added in commit 56576f4a722
("LoongArch: gas: Add support for linker relaxation."), in order to
allow calling _bfd_read_unsigned_leb128 from gas, but doing so broke
shared builds. Commit d2fddb6d783 fixed this reference but did not
remove the now unnecessary inclusion of libbfd.h. The gas_assert macro
expands into a conditional call to abort(), but "abort" is re-defined to
_bfd_abort in libbfd.h, so the extra include breaks any gas_assert
usage, and should be removed.
gas/ChangeLog:
* config/tc-loongarch.c: Don't include libbfd.h.
Fixes: d2fddb6d783 ("LoongArch: Fix ld "undefined reference" error with --enable-shared")
Signed-off-by: WANG Xuerui <git@xen0n.name>
Diff:
---
gas/config/tc-loongarch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gas/config/tc-loongarch.c b/gas/config/tc-loongarch.c
index 439bde18b7d..2e8a259d147 100644
--- a/gas/config/tc-loongarch.c
+++ b/gas/config/tc-loongarch.c
@@ -31,7 +31,6 @@
#include <string.h>
#include <stdio.h>
#include <assert.h>
-#include "libbfd.h"
/* All information about an instruction during assemble. */
struct loongarch_cl_insn
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-03 1:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 1:04 [binutils-gdb] LoongArch: gas: Fix shared builds liu & zhensong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).