* [binutils-gdb] score: drop .bss override
@ 2024-01-05 7:10 Jan Beulich
0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2024-01-05 7:10 UTC (permalink / raw)
To: bfd-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6d2efd156d265bece92d86988437e4c3c7898f3c
commit 6d2efd156d265bece92d86988437e4c3c7898f3c
Author: Jan Beulich <jbeulich@suse.com>
Date: Fri Jan 5 08:10:21 2024 +0100
score: drop .bss override
The comment looks bogus (perhaps simply stale, or wrongly copied from
another target). It also doesn't look to be a good idea to override the
custom handler that ELF has (afaict doing so broke .previous as well as
sub-section specification).
While there also fold the identical handlers for .text (there likely is
more room for such folding).
Diff:
---
gas/config/tc-score.c | 35 ++---------------------------------
gas/config/tc-score7.c | 15 ---------------
2 files changed, 2 insertions(+), 48 deletions(-)
diff --git a/gas/config/tc-score.c b/gas/config/tc-score.c
index 0559c564eb8..116c7aa61a5 100644
--- a/gas/config/tc-score.c
+++ b/gas/config/tc-score.c
@@ -24,8 +24,6 @@
#include "tc-score7.c"
-static void s3_s_score_bss (int ignore ATTRIBUTE_UNUSED);
-static void s3_s_score_text (int ignore);
static void s3_score_s_section (int ignore);
static void s3_s_change_sec (int sec);
static void s3_s_score_mask (int reg_type ATTRIBUTE_UNUSED);
@@ -39,7 +37,6 @@ static void s3_s_score_gpword (int ignore ATTRIBUTE_UNUSED);
static void s3_s_score_cpadd (int ignore ATTRIBUTE_UNUSED);
static void s3_s_score_lcomm (int bytes_p);
-static void s_score_bss (int ignore ATTRIBUTE_UNUSED);
static void s_score_text (int ignore);
static void s_section (int ignore);
static void s_change_sec (int sec);
@@ -196,7 +193,6 @@ symbolS *GOT_symbol;
const pseudo_typeS md_pseudo_table[] =
{
- {"bss", s_score_bss, 0},
{"text", s_score_text, 0},
{"word", cons, 4},
{"long", cons, 4},
@@ -5532,22 +5528,6 @@ s3_do_dsp3 (char *str)
s3_inst.relax_inst = 0x8000;
}
-
-/* If we change section we must dump the literal pool first. */
-static void
-s3_s_score_bss (int ignore ATTRIBUTE_UNUSED)
-{
- subseg_set (bss_section, (subsegT) get_absolute_expression ());
- demand_empty_rest_of_line ();
-}
-
-static void
-s3_s_score_text (int ignore)
-{
- obj_elf_text (ignore);
- record_alignment (now_seg, 2);
-}
-
static void
s3_score_s_section (int ignore)
{
@@ -6323,22 +6303,11 @@ s3_build_dependency_insn_hsh (void)
}
}
-static void
-s_score_bss (int ignore ATTRIBUTE_UNUSED)
-{
- if (score3)
- return s3_s_score_bss (ignore);
- else
- return s7_s_score_bss (ignore);
-}
-
static void
s_score_text (int ignore)
{
- if (score3)
- return s3_s_score_text (ignore);
- else
- return s7_s_score_text (ignore);
+ obj_elf_text (ignore);
+ record_alignment (now_seg, 2);
}
static void
diff --git a/gas/config/tc-score7.c b/gas/config/tc-score7.c
index 71307f596dc..52cb8713400 100644
--- a/gas/config/tc-score7.c
+++ b/gas/config/tc-score7.c
@@ -5367,21 +5367,6 @@ s7_build_reg_hsh (struct s7_reg_map *map)
\f
-/* If we change section we must dump the literal pool first. */
-static void
-s7_s_score_bss (int ignore ATTRIBUTE_UNUSED)
-{
- subseg_set (bss_section, (subsegT) get_absolute_expression ());
- demand_empty_rest_of_line ();
-}
-
-static void
-s7_s_score_text (int ignore)
-{
- obj_elf_text (ignore);
- record_alignment (now_seg, 2);
-}
-
static void
s7_s_section (int ignore)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-05 7:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-05 7:10 [binutils-gdb] score: drop .bss override Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).