From: Alex Coplan <acoplan@sourceware.org>
To: binutils-cvs@sourceware.org
Subject: [binutils-gdb] arm: Refactor condition for print_mve_shift_n
Date: Tue, 9 Apr 2024 10:00:49 +0000 (GMT) [thread overview]
Message-ID: <20240409100049.586C43858CDB@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f9d6cf2e9f885a1504b459cf437dd9d1931b1168
commit f9d6cf2e9f885a1504b459cf437dd9d1931b1168
Author: Alex Coplan <alex.coplan@arm.com>
Date: Tue Apr 2 14:03:38 2024 +0100
arm: Refactor condition for print_mve_shift_n
This is intended to have no functional change, but refactors the
condition guarding the call to print_mve_shift_n in arm-dis.c ahead of a
later patch which adds additional insns to the set of those whose
shift immediate is disassembled using print_mve_shift_n.
Diff:
---
opcodes/arm-dis.c | 35 +++++++++++++++++++++++++----------
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index 40f7fb3d780..ac5fb921d23 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -7965,6 +7965,30 @@ print_mve_size (struct disassemble_info *info,
}
}
+/* Return true if INSN is a shift insn with an immediate shift amount
+ which needs decoding as per print_mve_shift_n. */
+
+static bool
+mve_shift_insn_p (enum mve_instructions insn)
+{
+ switch (insn)
+ {
+ case MVE_VQSHL_T2:
+ case MVE_VQSHLU_T3:
+ case MVE_VRSHR:
+ case MVE_VRSHRN:
+ case MVE_VSHL_T1:
+ case MVE_VSHLL_T1:
+ case MVE_VSHR:
+ case MVE_VSHRN:
+ case MVE_VSLI:
+ case MVE_VSRI:
+ return true;
+ default:
+ return false;
+ }
+}
+
static void
print_mve_shift_n (struct disassemble_info *info, long given,
enum mve_instructions matched_insn)
@@ -10225,16 +10249,7 @@ print_insn_mve (struct disassemble_info *info, long given)
arm_regnames[value]);
break;
case 'd':
- if (insn->mve_op == MVE_VQSHL_T2
- || insn->mve_op == MVE_VQSHLU_T3
- || insn->mve_op == MVE_VRSHR
- || insn->mve_op == MVE_VRSHRN
- || insn->mve_op == MVE_VSHL_T1
- || insn->mve_op == MVE_VSHLL_T1
- || insn->mve_op == MVE_VSHR
- || insn->mve_op == MVE_VSHRN
- || insn->mve_op == MVE_VSLI
- || insn->mve_op == MVE_VSRI)
+ if (mve_shift_insn_p (insn->mve_op))
print_mve_shift_n (info, given, insn->mve_op);
else if (insn->mve_op == MVE_VSHLL_T2)
{
reply other threads:[~2024-04-09 10:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409100049.586C43858CDB@sourceware.org \
--to=acoplan@sourceware.org \
--cc=binutils-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).