From: H.J. Lu <hjl@sourceware.org>
To: binutils-cvs@sourceware.org
Subject: [binutils-gdb] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts
Date: Tue, 23 Apr 2024 15:38:18 +0000 (GMT) [thread overview]
Message-ID: <20240423153819.7CBB03858417@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6c2119acf78b4a48caa918c1d63aac7a64a19c82
commit 6c2119acf78b4a48caa918c1d63aac7a64a19c82
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Tue Apr 23 07:07:51 2024 -0700
objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts
Use long with bfd_copy_private_symbol_data to fix
.../binutils/objcopy.c: In
function ‘copy_object’:
.../binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘long int’ [-Werror=sign-compare]
3383 | for (i = 0; i < symcount; i++)
| ^
on 32-bit hosts.
PR binutils/14493
* objcopy.c (copy_object): Use long with
bfd_copy_private_symbol_data.
Diff:
---
binutils/objcopy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index 634ebae3fc3..e8ca1374935 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch)
symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount);
}
- for (i = 0; i < symcount; i++)
- if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i]))
+ for (long s = 0; s < symcount; s++)
+ if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s]))
{
status = 1;
return false;
reply other threads:[~2024-04-23 15:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423153819.7CBB03858417@sourceware.org \
--to=hjl@sourceware.org \
--cc=binutils-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).