public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: <zac.walker@linaro.org>
To: <binutils@sourceware.org>
Subject: RE: [PATCH v3] aarch64-pe support for LD, GAS and BFD
Date: Wed, 19 Oct 2022 11:48:56 +0200	[thread overview]
Message-ID: <000401d8e3a0$0373e8b0$0a5bba10$@linaro.org> (raw)
In-Reply-To: <027ae69a-636b-6757-297a-eec42936401e@linaro.org>

Sorry - this patch caused a build break:

checking for PT_GETDBREGS... /usr/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.data.rel.ro+0x48): undefined reference to `aarch64_pe_le_vec'
/usr/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.data.rel.ro+0x17c0): undefined reference to `aarch64_pe_le_vec'
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:1276: as-new] Error 1

Investigating now and hope to fix soon (or roll back.)

Zac

-----Original Message-----
From: Zac Walker <zac.walker@linaro.org> 
Sent: 14 October 2022 09:58
To: binutils@sourceware.org
Subject: [PATCH v3] aarch64-pe support for LD, GAS and BFD

V3 of the patch originally written by Jedidiah Thompson. It allows aarch64-pe to be targeted natively, not having to use objcopy to convert it from ELF to PE.


Between V2 and V3 I made a few recommended updates most notably adding the missing BFD_RELOC_AARCH64_BRANCH19 and additional const correctness. I have included a diff between patches v2 and v3. Patch and diff included as attachments to avoid text formatting issues.


Changes since that original patch:

- Added minimal relocation support and tested generated binaries run on a Surface-ProX ARM64 test machine.

- Been through a review process with colleagues at Linaro. Linaro has agreed to run CI for aarch64-pe going forward in their test lab.

- Run tests for multiple platforms; aarch64-linux-gnu, x86_64-linux-gnu, x86_64-w64-mingw32. Those tests pass and see no regressions. Multiple GAS tests still fail for aarch64-pe because of ELF specific assumptions. I plan to fix these later.


The long-term goal of this work is to help enable MSYS2 for Window on ARM64. As discussed here: https://github.com/msys2/MSYS2-packages/issues/1888


The original work by Jedidiah Thompson here can be found here: https://sourceware.org/pipermail/binutils/2022-January/119077.html


Regards,
Zac Walker


  parent reply	other threads:[~2022-10-19  9:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  7:58 Zac Walker
2022-10-17 12:20 ` Nick Clifton
2022-10-19  9:48 ` zac.walker [this message]
2022-10-19 11:14   ` Andrew Burgess
2022-10-19 11:51     ` zac.walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000401d8e3a0$0373e8b0$0a5bba10$@linaro.org' \
    --to=zac.walker@linaro.org \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).