From: Andrew Burgess <aburgess@redhat.com>
To: zac.walker@linaro.org, binutils@sourceware.org
Subject: RE: [PATCH v3] aarch64-pe support for LD, GAS and BFD
Date: Wed, 19 Oct 2022 12:14:22 +0100 [thread overview]
Message-ID: <871qr4awvl.fsf@redhat.com> (raw)
In-Reply-To: <000401d8e3a0$0373e8b0$0a5bba10$@linaro.org>
Zac Walker via Binutils <binutils@sourceware.org> writes:
> Sorry - this patch caused a build break:
>
> checking for PT_GETDBREGS... /usr/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.data.rel.ro+0x48): undefined reference to `aarch64_pe_le_vec'
> /usr/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.data.rel.ro+0x17c0): undefined reference to `aarch64_pe_le_vec'
> collect2: error: ld returned 1 exit status
> make[4]: *** [Makefile:1276: as-new] Error 1
>
> Investigating now and hope to fix soon (or roll back.)
I just pushed the patch below to fix this issue. Just needed to run
autoreconf.
Thanks,
Andrew
---
commit 6d6ae7c23dd59fe16f3e366e969b927d97fe5e01
Author: Andrew Burgess <aburgess@redhat.com>
Date: Wed Oct 19 12:00:42 2022 +0100
bfd: fix undefined references to aarch64_pe_le_vec
After commit:
commit c60b3806799abf1d7f6cf5108a1b0e733a950b13
Date: Wed Oct 19 10:57:12 2022 +0200
aarch64-pe support for LD, GAS and BFD
It appears that bfd/Makefile.in and bfd/configure were not regenerated
correctly. The differences in the configure file are only whitespace,
but in Makefile.in a critical reference to pe-aarch64.lo was missing.
diff --git a/bfd/Makefile.in b/bfd/Makefile.in
index 3f520355829..b906976a1c0 100644
--- a/bfd/Makefile.in
+++ b/bfd/Makefile.in
@@ -1048,6 +1048,7 @@ BFD64_BACKENDS = \
pe-loongarch64igen.lo \
pe-x86_64.lo \
pei-aarch64.lo \
+ pe-aarch64.lo \
pei-ia64.lo \
pei-loongarch64.lo \
pei-x86_64.lo \
@@ -1700,6 +1701,7 @@ distclean-compile:
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pc532-mach.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pdb.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pdp11.Plo@am__quote@
+@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-aarch64.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-aarch64igen.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-arm-wince.Plo@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-arm.Plo@am__quote@
diff --git a/bfd/configure b/bfd/configure
index bae9d17c515..1c1760670cb 100755
--- a/bfd/configure
+++ b/bfd/configure
@@ -13604,7 +13604,7 @@ do
aarch64_elf64_le_cloudabi_vec) tb="$tb elf64-aarch64.lo elfxx-aarch64.lo elf-ifunc.lo elf64.lo $elf"; target_size=64 ;;
aarch64_mach_o_vec) tb="$tb mach-o-aarch64.lo"; target_size=64 ;;
aarch64_pei_le_vec) tb="$tb pei-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;;
- aarch64_pe_le_vec) tb="$tb pe-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;;
+ aarch64_pe_le_vec) tb="$tb pe-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;;
alpha_ecoff_le_vec) tb="$tb coff-alpha.lo ecoff.lo $ecoff"; target_size=64 ;;
alpha_elf64_vec) tb="$tb elf64-alpha.lo elf64.lo $elf"; target_size=64 ;;
alpha_elf64_fbsd_vec) tb="$tb elf64-alpha.lo elf64.lo $elf"; target_size=64 ;;
next prev parent reply other threads:[~2022-10-19 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 7:58 Zac Walker
2022-10-17 12:20 ` Nick Clifton
2022-10-19 9:48 ` zac.walker
2022-10-19 11:14 ` Andrew Burgess [this message]
2022-10-19 11:51 ` zac.walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qr4awvl.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=zac.walker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).