[RESEND PATCH 0/1] RISC-V: Update 'Zihintpause' extension version

[RESEND PATCH 0/1] RISC-V: Update 'Zihintpause' extension version

[Tsukasa OI]

Hi RISC-V folks,

`Zihintpause' extension actually has version 2.0 (not 1.0).  This patch
will fix the version value.

ORIG: <https://sourceware.org/pipermail/binutils/2022-May/120978.html>
PING: <https://sourceware.org/pipermail/binutils/2022-May/120978.html>

Some discussion record:
<https://sourceware.org/pipermail/binutils/2022-February/119587.html>
Tracker on GitHub:
<https://github.com/a4lg/binutils-gdb/wiki/riscv_zihintpause_ver>


My copyright assignment is complete and I request review for
upstream merge.  To me,

1. This one and
2. Zhinx fix patchset (to make it to GNU Binutils 2.39 release)
   <https://sourceware.org/pipermail/binutils/2022-June/121416.html>
   <https://github.com/a4lg/binutils-gdb/wiki/riscv_zhinx_quick_fix>

are two important patchsets intended for GNU Binutils 2.39 (to minimize
confusion and compatibility problems as possible).

I can say that all my other submissions can be postponed for Binutils
2.40 or later.  I understand that committers are busy right now but
I think I could minimize the patchsets to review until 2.39 branch date.

I am so sorry to rush you.


Thanks,
Tsukasa




Tsukasa OI (1):
  RISC-V: Update Zihintpause extension version

 bfd/elfxx-riscv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: dcc9b683dc7d6b0c8e64bfa5e11cf0830387bb31
-- 
2.25.1

[RESEND PATCH 1/1] RISC-V: Update Zihintpause extension version

[Tsukasa OI]

Because ratified Zihintpause extension has a version number of 2.0
(not 1.0), we should update the number.

bfd/ChangeLog:

	* elfxx-riscv.c (riscv_supported_std_z_ext): Update version
	number of Zihintpause extension.
---
 bfd/elfxx-riscv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index bf7dc20e892..c846d6baaa2 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -1185,7 +1185,7 @@ static struct riscv_supported_ext riscv_supported_std_z_ext[] =
   {"zicsr",		ISA_SPEC_CLASS_20190608,	2, 0,  0 },
   {"zifencei",		ISA_SPEC_CLASS_20191213,	2, 0,  0 },
   {"zifencei",		ISA_SPEC_CLASS_20190608,	2, 0,  0 },
-  {"zihintpause",	ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
+  {"zihintpause",	ISA_SPEC_CLASS_DRAFT,		2, 0,  0 },
   {"zfh",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
   {"zfinx",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
   {"zdinx",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
-- 
2.25.1

Re: [RESEND PATCH 1/1] RISC-V: Update Zihintpause extension version

[Nelson Chu]

OK, thanks, committed.

Nelson

On Sun, Jul 3, 2022 at 6:31 PM Tsukasa OI <research_trasio@irq.a4lg.com> wrote:
>
> Because ratified Zihintpause extension has a version number of 2.0
> (not 1.0), we should update the number.
>
> bfd/ChangeLog:
>
>         * elfxx-riscv.c (riscv_supported_std_z_ext): Update version
>         number of Zihintpause extension.
> ---
>  bfd/elfxx-riscv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index bf7dc20e892..c846d6baaa2 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -1185,7 +1185,7 @@ static struct riscv_supported_ext riscv_supported_std_z_ext[] =
>    {"zicsr",            ISA_SPEC_CLASS_20190608,        2, 0,  0 },
>    {"zifencei",         ISA_SPEC_CLASS_20191213,        2, 0,  0 },
>    {"zifencei",         ISA_SPEC_CLASS_20190608,        2, 0,  0 },
> -  {"zihintpause",      ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
> +  {"zihintpause",      ISA_SPEC_CLASS_DRAFT,           2, 0,  0 },
>    {"zfh",              ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>    {"zfinx",            ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>    {"zdinx",            ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
> --
> 2.25.1
>

Re: [RESEND PATCH 1/1] RISC-V: Update Zihintpause extension version

[Jan Beulich]

On 03.07.2022 12:31, Tsukasa OI via Binutils wrote:
> Because ratified Zihintpause extension has a version number of 2.0
> (not 1.0), we should update the number.
> 
> bfd/ChangeLog:
> 
> 	* elfxx-riscv.c (riscv_supported_std_z_ext): Update version
> 	number of Zihintpause extension.
> ---
>  bfd/elfxx-riscv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index bf7dc20e892..c846d6baaa2 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -1185,7 +1185,7 @@ static struct riscv_supported_ext riscv_supported_std_z_ext[] =
>    {"zicsr",		ISA_SPEC_CLASS_20190608,	2, 0,  0 },
>    {"zifencei",		ISA_SPEC_CLASS_20191213,	2, 0,  0 },
>    {"zifencei",		ISA_SPEC_CLASS_20190608,	2, 0,  0 },
> -  {"zihintpause",	ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
> +  {"zihintpause",	ISA_SPEC_CLASS_DRAFT,		2, 0,  0 },
>    {"zfh",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
>    {"zfinx",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
>    {"zdinx",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },

Just for my own education: Isn't the general versioning scheme using
2.x only for non-draft functionality?

Jan

Re: [RESEND PATCH 1/1] RISC-V: Update Zihintpause extension version

[Kito Cheng]

> Just for my own education: Isn't the general versioning scheme using
> 2.x only for non-draft functionality?

Version scheme has *slightly* changed, RISC-V uses 2.0 as raritfed
version number, and 2.x for non-draft functionality change,
and now RISC-V uses 1.0 as a ratified version.

More discussion you can found here:

https://sourceware.org/pipermail/binutils/2022-February/119587.html

But I must say I still can't figure out what happened on zihintpause
after reading the thread...