public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: <zac.walker@linaro.org>
To: "'Alan Modra'" <amodra@gmail.com>
Cc: "'Nick Clifton'" <nickc@redhat.com>, <binutils@sourceware.org>
Subject: RE: aarch64-pe can't fill 16 bytes in section .text
Date: Fri, 18 Nov 2022 09:52:08 +0100	[thread overview]
Message-ID: <022601d8fb2b$0ae69a00$20b3ce00$@linaro.org> (raw)
In-Reply-To: <Y3WkHnIxHg/EJcKN@squeak.grove.modra.org>

Patch merged just now. (Was a holiday here yesterday)

I am still investigating another alignment problem so might be another follow up patch. This code from OpenBLAS:

data_ar:
 .word 0x3e44fae6
data_ai:
 .word 0x3d320fa2
start:
 ldr s20, data_ar
 ldr s21, data_ai 

Produces:

zscal-min.s:2: Warning: value 0x3e44fae6 truncated to 0xfae6
zscal-min.s:4: Warning: value 0x3d320fa2 truncated to 0xfa2
zscal-min.s:7: Error: pc-relative load offset not word aligned

Works ok with clang. I am not sure if .word data should be aligned by default in gas or this is just a difference in behaviour.

Thanks,
Zac

-----Original Message-----
From: Alan Modra <amodra@gmail.com> 
Sent: 17 November 2022 04:02
To: Zac Walker <zac.walker@linaro.org>
Cc: Nick Clifton <nickc@redhat.com>; binutils@sourceware.org
Subject: Re: aarch64-pe can't fill 16 bytes in section .text

On Wed, Nov 16, 2022 at 06:03:56PM +0100, Zac Walker wrote:
> Thanks Alan,
> 
> Do you think my SUB_SEGMENT_ALIGN patch is still needed. I didn't merge it yet because I wanted to do more testing with your fix.

Huh, I thought it had already gone in, but it was just in my local tree.

Your patch isn't needed with my fix to obj-coff.c, but it wouldn't be a bad idea to apply it anyway.  We have a few too many places
doing section padding.  It would be nice to get rid of the alignment code in coff_frob_section.

--
Alan Modra
Australia Development Lab, IBM


  reply	other threads:[~2022-11-18  8:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 17:24 [PATCH V2] GAS fix alignment for aarch64-pe Zac Walker
2022-11-15 10:50 ` Nick Clifton
2022-11-15 11:23   ` Zac Walker
2022-11-15 21:53     ` aarch64-pe can't fill 16 bytes in section .text Alan Modra
2022-11-16 17:03       ` Zac Walker
2022-11-17  3:01         ` Alan Modra
2022-11-18  8:52           ` zac.walker [this message]
2022-11-18  9:08             ` Jan Beulich
2022-11-18  9:35               ` zac.walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='022601d8fb2b$0ae69a00$20b3ce00$@linaro.org' \
    --to=zac.walker@linaro.org \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).