From: Zac Walker <zac.walker@linaro.org>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH V2] GAS fix alignment for aarch64-pe
Date: Tue, 15 Nov 2022 12:23:10 +0100 [thread overview]
Message-ID: <584ecd9c-7876-8e2f-4610-8b51cab366b8@linaro.org> (raw)
In-Reply-To: <1fc98550-06e7-284e-3f1c-dda991bdd0e5@redhat.com>
Thanks Nick.
On 11/15/22 11:50, Nick Clifton wrote:
> Hi Zac,
>
>> For the aarch64-pe target various values of '.align' causes writing of COFF files to fail.
>>
>> This version of the patch differs from the first by using the write.c implementation of SUB_SEGMENT_ALIGN. This means there was no need to modify md_section_align or aarch64_handle_align. The change is specific to the aarch64-pe target.
>>
>> In my testing generated aligned code was correctly padded with nop.
>
> Patch approved - please apply.
>
> Cheers
> Nick
>
next prev parent reply other threads:[~2022-11-15 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 17:24 Zac Walker
2022-11-15 10:50 ` Nick Clifton
2022-11-15 11:23 ` Zac Walker [this message]
2022-11-15 21:53 ` aarch64-pe can't fill 16 bytes in section .text Alan Modra
2022-11-16 17:03 ` Zac Walker
2022-11-17 3:01 ` Alan Modra
2022-11-18 8:52 ` zac.walker
2022-11-18 9:08 ` Jan Beulich
2022-11-18 9:35 ` zac.walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=584ecd9c-7876-8e2f-4610-8b51cab366b8@linaro.org \
--to=zac.walker@linaro.org \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).