Re: [PATCH, needs more eyes] Relink also libopcodes and libgprofng to newly built libiberty.a

[Jan Beulich <jbeulich@suse.com>]

On 28.02.2023 23:49, Andreas K. Hüttel via Binutils wrote:
> For Gentoo users, after updating gcc, a subsequent build of
> binutils can fail during "make install" with the following symptoms:
> 
> lto1: fatal error: bytecode stream in file '/usr/lib64/binutils/x86_64-pc-linux-gnu/2.37_p1/libiberty.a' generated with LTO version 11.0 instead of the expected 11.2
> compilation terminated.
> 
> The relink command picks up the installed version of libiberty.a
> instead of the just built one. This commit addresses the issue by
> replicating the workaround made in 7d53105d for libctf also for
> libopcodes and libgprofng.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29042
> Bug: https://bugs.gentoo.org/834720
> Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

Looks largely okay to me, but please add comments along the lines of the
one found in libctf/Makefile.am.

I'm not going to ask ...

> ---
>  gprofng/src/Makefile.am | 3 ++-
>  gprofng/src/Makefile.in | 3 ++-
>  opcodes/configure       | 4 ++--
>  opcodes/configure.ac    | 4 ++--
>  4 files changed, 8 insertions(+), 6 deletions(-)

... why libopcodes handles this in configure rather than in Makefile, as
that's a pre-existing (apparent) oddity.

Jan