Re: [PATCH, needs more eyes] Relink also libopcodes and libgprofng to newly built libiberty.a

[Vladimir Mezentsev <vladimir.mezentsev@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 7049 bytes --]

  Hi Andreas,

  Your fix fixes gprofng bug 29987 - bfd/archive.c:1447: undefined 
reference to `filename_ncmp' 
<https://sourceware.org/bugzilla/show_bug.cgi?id=29987>

  But It is a workaround of problem.
I think the problem is in the libbfd build.

% ../binutils-gdb.git/configure --with-system-zlib 
--with-system-readline --enable-default-hash-style=gnu --enable-gold 
--without-guile 
--disable-{gdb,gdbserver,libbacktrace,libdecnumber,readline,sim}
% make -j 20 2>&1 | tee make.log

% grep 'skipping incompatible' make.log
/usr/local/bin/ld: skipping incompatible /usr/lib/libz.so when searching 
for -lz
/usr/local/bin/ld: skipping incompatible /usr/lib/libdl.so when 
searching for -ldl
/usr/local/bin/ld: skipping incompatible /usr/lib/libc.so when searching 
for -lc
/usr/local/bin/ld: skipping incompatible /usr/lib/libz.so when searching 
for -lz
/usr/local/bin/ld: skipping incompatible /usr/lib/libm.so when searching 
for -lm
...

We see these warnings because libtool added -L/usr/lib

% grep L/usr/lib make.log
libtool: link: g++ -Wall -pthread -Wno-switch -g -O2 -o gp-archive 
gp-archive.o ArchiveExp.o  ./.libs/libgprofng.a 
-L/dev/shm/bld-binutils-gdb/libiberty -L/usr/lib 
/dev/shm/bld-binutils-gdb/opcodes/.libs/libopcodes.a 
/dev/shm/bld-binutils-gdb/bfd/.libs/libbfd.a -lzstd 
/dev/shm/bld-binutils-gdb/libsframe/.libs/libsframe.a -liberty -lpthread 
-ldl -lz -pthread
libtool: link: g++ -Wall -pthread -Wno-switch -g -O2 -o gp-collect-app 
gp-collect-app.o checks.o envsets.o count.o ./.libs/libgprofng.a 
-L/dev/shm/bld-binutils-gdb/libiberty -L/usr/lib 
/dev/shm/bld-binutils-gdb/opcodes/.libs/libopcodes.a 
/dev/shm/bld-binutils-gdb/bfd/.libs/libbfd.a -lzstd 
/dev/shm/bld-binutils-gdb/libsframe/.libs/libsframe.a -liberty -lpthread 
-ldl -lz -pthread
libtool: link: g++ -Wall -pthread -Wno-switch -g -O2 -o gprofng 
gprofng.o  ./.libs/libgprofng.a -L/dev/shm/bld-binutils-gdb/libiberty 
-L/usr/lib /dev/shm/bld-binutils-gdb/opcodes/.libs/libopcodes.a 
/dev/shm/bld-binutils-gdb/bfd/.libs/libbfd.a -lzstd 
/dev/shm/bld-binutils-gdb/libsframe/.libs/libsframe.a -liberty -lpthread 
-ldl -lz -pthread
libtool: link: g++ -Wall -pthread -Wno-switch -g -O2 -o gp-display-text 
gp-display-text.o ipc.o ipcio.o ./.libs/libgprofng.a 
-L/dev/shm/bld-binutils-gdb/libiberty -L/usr/lib 
/dev/shm/bld-binutils-gdb/opcodes/.libs/libopcodes.a 
/dev/shm/bld-binutils-gdb/bfd/.libs/libbfd.a -lzstd 
/dev/shm/bld-binutils-gdb/libsframe/.libs/libsframe.a -liberty -lpthread 
-ldl -lz -pthread
libtool: link: g++ -Wall -pthread -Wno-switch -g -O2 -o gp-display-src 
gp-display-src.o  ./.libs/libgprofng.a 
-L/dev/shm/bld-binutils-gdb/libiberty -L/usr/lib 
/dev/shm/bld-binutils-gdb/opcodes/.libs/libopcodes.a 
/dev/shm/bld-binutils-gdb/bfd/.libs/libbfd.a -lzstd 
/dev/shm/bld-binutils-gdb/libsframe/.libs/libsframe.a -liberty -lpthread 
-ldl -lz -pthread

I think libtool added -L/usr/lib because gprofng and libsframe are 
linked with bfd/libbfd.la and
libbfd.la has a wrong dependency:

% grep L/usr/lib bfd/libbfd.la
dependency_libs=' -lz -L/usr/lib -lzstd 
/dev/shm/bld-binutils-gdb/libsframe/libsframe.la -ldl'

-L/usr/lib should not be here.
It can be -L/usr/lib64 but not -L/usr/lib in the 64-bit build.

Thank you,
-Vladimir




On 2/28/23 14:49, Andreas K. Hüttel via Binutils wrote:
> For Gentoo users, after updating gcc, a subsequent build of
> binutils can fail during "make install" with the following symptoms:
>
> lto1: fatal error: bytecode stream in file '/usr/lib64/binutils/x86_64-pc-linux-gnu/2.37_p1/libiberty.a' generated with LTO version 11.0 instead of the expected 11.2
> compilation terminated.
>
> The relink command picks up the installed version of libiberty.a
> instead of the just built one. This commit addresses the issue by
> replicating the workaround made in 7d53105d for libctf also for
> libopcodes and libgprofng.
>
> Bug:https://sourceware.org/bugzilla/show_bug.cgi?id=29042
> Bug:https://bugs.gentoo.org/834720
> Signed-off-by: Andreas K. Hüttel<dilfridge@gentoo.org>
> ---
>   gprofng/src/Makefile.am | 3 ++-
>   gprofng/src/Makefile.in | 3 ++-
>   opcodes/configure       | 4 ++--
>   opcodes/configure.ac    | 4 ++--
>   4 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/gprofng/src/Makefile.am b/gprofng/src/Makefile.am
> index ab90bb08c5f..96256faf788 100644
> --- a/gprofng/src/Makefile.am
> +++ b/gprofng/src/Makefile.am
> @@ -131,7 +131,8 @@ libgprofng_la_LDFLAGS = -version-info 0:0:0
>   # Pass -lpthread instead of $(PTHREAD_LIBS) due to $(PTHREAD_LIBS) being empty
>   # when -nostdlib is passed to libtool.
>   # See bug 29364 - libgprofng.so: needs to link against -pthread
> -libgprofng_la_LIBADD = $(top_builddir)/../opcodes/libopcodes.la \
> +libgprofng_la_LIBADD = $(GPROFNG_LIBADD) \
> +	$(top_builddir)/../opcodes/libopcodes.la \
>   	$(top_builddir)/../bfd/libbfd.la \
>   	$(GPROFNG_LIBADD) \
>   	-lpthread -ldl
> diff --git a/gprofng/src/Makefile.in b/gprofng/src/Makefile.in
> index 605fa4f6fd4..f968d8d6e59 100644
> --- a/gprofng/src/Makefile.in
> +++ b/gprofng/src/Makefile.in
> @@ -555,7 +555,8 @@ libgprofng_la_LDFLAGS = -version-info 0:0:0
>   # Pass -lpthread instead of $(PTHREAD_LIBS) due to $(PTHREAD_LIBS) being empty
>   # when -nostdlib is passed to libtool.
>   # See bug 29364 - libgprofng.so: needs to link against -pthread
> -libgprofng_la_LIBADD = $(top_builddir)/../opcodes/libopcodes.la \
> +libgprofng_la_LIBADD = $(GPROFNG_LIBADD) \
> +	$(top_builddir)/../opcodes/libopcodes.la \
>   	$(top_builddir)/../bfd/libbfd.la \
>   	$(GPROFNG_LIBADD) \
>   	-lpthread -ldl
> diff --git a/opcodes/configure b/opcodes/configure
> index 8717d99ca26..fbdf41f87be 100755
> --- a/opcodes/configure
> +++ b/opcodes/configure
> @@ -12445,10 +12445,10 @@ if test "$enable_shared" = "yes"; then
>     case "${host}" in
>       *-*-cygwin*)
>         SHARED_LDFLAGS="-no-undefined"
> -      SHARED_LIBADD="-L`pwd`/../bfd -lbfd -L`pwd`/../libiberty -liberty $SHARED_LIBADD"
> +      SHARED_LIBADD="$SHARED_LIBADD -L`pwd`/../bfd -lbfd -L`pwd`/../libiberty -liberty $SHARED_LIBADD"
>         ;;
>       *)
> -      SHARED_LIBADD="../bfd/libbfd.la ${SHARED_LIBADD}"
> +      SHARED_LIBADD="${SHARED_LIBADD} ../bfd/libbfd.la ${SHARED_LIBADD}"
>         SHARED_DEPENDENCIES="../bfd/libbfd.la"
>         ;;
>     esac
> diff --git a/opcodes/configure.ac b/opcodes/configure.ac
> index 1beb72e87e0..79310916f7d 100644
> --- a/opcodes/configure.ac
> +++ b/opcodes/configure.ac
> @@ -193,10 +193,10 @@ if test "$enable_shared" = "yes"; then
>     case "${host}" in
>       *-*-cygwin*)
>         SHARED_LDFLAGS="-no-undefined"
> -      SHARED_LIBADD="-L`pwd`/../bfd -lbfd -L`pwd`/../libiberty -liberty $SHARED_LIBADD"
> +      SHARED_LIBADD="$SHARED_LIBADD -L`pwd`/../bfd -lbfd -L`pwd`/../libiberty -liberty $SHARED_LIBADD"
>         ;;
>       *)
> -      SHARED_LIBADD="../bfd/libbfd.la ${SHARED_LIBADD}"
> +      SHARED_LIBADD="${SHARED_LIBADD} ../bfd/libbfd.la ${SHARED_LIBADD}"
>         SHARED_DEPENDENCIES="../bfd/libbfd.la"
>         ;;
>     esac