From: Mark Harmstone <mark@harmstone.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2] ld: Sort section contributions in PDB files
Date: Tue, 28 Feb 2023 00:18:38 +0000 [thread overview]
Message-ID: <067d464d-2a2d-3dc2-9b33-afd716ecc1f4@harmstone.com> (raw)
In-Reply-To: <3aeaf40a-f59c-32be-9fad-1efc18ce6bcb@suse.com>
On 27/02/2023 09:13, Jan Beulich wrote:
> On 27.02.2023 01:59, Mark Harmstone wrote:
>> + qsort (sc_in, num_sc, sizeof (struct in_sc), section_contribs_compare);
> You want to apply Nick's requested change here as well, changing
> sizeof (struct in_sc) to sizeof (* sc_in). Okay with that adjustment,
> assuming ...
Thanks Jan. I'll push it with that change, then.
>> + ptr = *data;
>> + sc = (struct section_contribution *) (ptr + 1); /* Skip the version word. */
> ... you did at least consider Nick's remark regarding this, but
> didn't find any good replacement (and Nick's suggestion also didn't
> fit).
Well, that was one of Nick's suggestions, and as Alan says it's a matter of taste.
Mark
prev parent reply other threads:[~2023-02-28 0:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 0:59 Mark Harmstone
2023-02-27 9:13 ` Jan Beulich
2023-02-28 0:18 ` Mark Harmstone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=067d464d-2a2d-3dc2-9b33-afd716ecc1f4@harmstone.com \
--to=mark@harmstone.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).