From: Jan Beulich <jbeulich@suse.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] ld: Fix segfault in populate_publics_stream
Date: Wed, 30 Nov 2022 08:00:52 +0100 [thread overview]
Message-ID: <0b10cbe7-7df2-ee8a-327a-f7cfa2e9d2be@suse.com> (raw)
In-Reply-To: <8082e0e2-5c01-8ce6-e447-3dce8e689c66@harmstone.com>
On 29.11.2022 18:47, Mark Harmstone wrote:
> > it ... should actually be accompanied by a code comment.
>
> Not really, as it was a straightforward mistake in my original patch. If I'd
> included a NULL check to begin with, I doubt anyone would have batted an
> eyelid.
Maybe. Depends on how close a review would have been done.
> I could have easily worked around this in my test, either by adding in a dummy
> section or by using the preprocessor rather than .equ, but figured that any
> way of causing a segfault is a bug that needs to be fixed.
Of course.
Jan
prev parent reply other threads:[~2022-11-30 7:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 2:53 [PATCH v2] ld: Generate PDB string table Mark Harmstone
2022-11-25 2:54 ` [PATCH] ld: Write DEBUG_S_FILECHKSMS entries in PDBs Mark Harmstone
2022-11-27 2:38 ` [PATCH] ld: Fix segfault in populate_publics_stream Mark Harmstone
2022-11-27 2:38 ` [PATCH] ld: Write DEBUG_S_LINES entries in PDB file Mark Harmstone
2022-11-29 0:10 ` [PATCH] ld: Write types into TPI stream of PDB Mark Harmstone
2022-11-29 0:10 ` [PATCH] ld: Write types into IPI " Mark Harmstone
2022-11-29 0:10 ` [PATCH] ld: Parse LF_UDT_SRC_LINE records when creating PDB file Mark Harmstone
2022-12-05 1:53 ` [PATCH] ld: Write globals stream in PDB Mark Harmstone
2022-12-05 1:53 ` [PATCH] ld: Copy other symbols into PDB file Mark Harmstone
2022-12-05 1:53 ` [PATCH] ld: Write linker symbols in PDB Mark Harmstone
2022-12-06 17:07 ` [PATCH] ld: Write globals stream " Nick Clifton
2022-12-06 17:52 ` Mark Harmstone
2022-12-08 11:00 ` Nick Clifton
2022-12-09 1:11 ` Mark Harmstone
2022-11-28 14:54 ` [PATCH] ld: Fix segfault in populate_publics_stream Jan Beulich
2022-11-28 17:53 ` Mark Harmstone
2022-11-29 9:00 ` Jan Beulich
2022-11-29 17:47 ` Mark Harmstone
2022-11-30 7:00 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b10cbe7-7df2-ee8a-327a-f7cfa2e9d2be@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).