From: Jan Beulich <jbeulich@suse.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] ld: Fix segfault in populate_publics_stream
Date: Mon, 28 Nov 2022 15:54:08 +0100 [thread overview]
Message-ID: <992f7462-5544-39fd-507c-bfeabf708db8@suse.com> (raw)
In-Reply-To: <20221127023840.32080-1-mark@harmstone.com>
On 27.11.2022 03:38, Mark Harmstone wrote:
> --- a/ld/pdb.c
> +++ b/ld/pdb.c
> @@ -1413,6 +1413,9 @@ populate_publics_stream (bfd *stream, bfd *abfd, bfd *sym_rec_stream)
Out of curiosity - which tree was this diff generated against? The
line number here looks to be off by several hundred from what I
see in the repo right now.
> for (bfd *in = coff_data (abfd)->link_info->input_bfds; in;
> in = in->link.next)
> {
> + if (!in->outsymbols)
> + continue;
> +
> for (unsigned int i = 0; i < in->symcount; i++)
> {
> struct bfd_symbol *sym = in->outsymbols[i];
Why / when would in->outsymbols be NULL but in->symcount be non-zero?
And if that was possible, why would it not also be possible that the
array is smaller than in->symcount? (This is the kind of questions
which arise when there's no description at all for a patch. Such a
description could have clarified under what special conditions a NULL
deref could happen despite it not being obviously possible.)
Jan
next prev parent reply other threads:[~2022-11-28 14:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 2:53 [PATCH v2] ld: Generate PDB string table Mark Harmstone
2022-11-25 2:54 ` [PATCH] ld: Write DEBUG_S_FILECHKSMS entries in PDBs Mark Harmstone
2022-11-27 2:38 ` [PATCH] ld: Fix segfault in populate_publics_stream Mark Harmstone
2022-11-27 2:38 ` [PATCH] ld: Write DEBUG_S_LINES entries in PDB file Mark Harmstone
2022-11-29 0:10 ` [PATCH] ld: Write types into TPI stream of PDB Mark Harmstone
2022-11-29 0:10 ` [PATCH] ld: Write types into IPI " Mark Harmstone
2022-11-29 0:10 ` [PATCH] ld: Parse LF_UDT_SRC_LINE records when creating PDB file Mark Harmstone
2022-12-05 1:53 ` [PATCH] ld: Write globals stream in PDB Mark Harmstone
2022-12-05 1:53 ` [PATCH] ld: Copy other symbols into PDB file Mark Harmstone
2022-12-05 1:53 ` [PATCH] ld: Write linker symbols in PDB Mark Harmstone
2022-12-06 17:07 ` [PATCH] ld: Write globals stream " Nick Clifton
2022-12-06 17:52 ` Mark Harmstone
2022-12-08 11:00 ` Nick Clifton
2022-12-09 1:11 ` Mark Harmstone
2022-11-28 14:54 ` Jan Beulich [this message]
2022-11-28 17:53 ` [PATCH] ld: Fix segfault in populate_publics_stream Mark Harmstone
2022-11-29 9:00 ` Jan Beulich
2022-11-29 17:47 ` Mark Harmstone
2022-11-30 7:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=992f7462-5544-39fd-507c-bfeabf708db8@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).