Re: [PATCH,RFC 3/7] libctfframe: add the CTF Frame library

[Jan Beulich <jbeulich@suse.com>]

On 09.05.2022 00:00, Indu Bhagat via Binutils wrote:
> On 5/6/22 5:52 PM, Indu Bhagat wrote:
>> From: Weimin Pan <weimin.pan@oracle.com>
>>
>> libctfframe is a library that allows you to:
>> - decode a .ctf_frame section
>> - probe and inspect a .ctf_frame section
>> - encode (and eventually write) a .ctf_frame section.
>>
>> This library is currently being used by the linker, readelf and objdump.
>> The file include/ctf-frame-api.h defines the user-facing APIs for decoding,
>> encoding and probing .ctf_frame sections. A set of error codes together
>> with their error message strings are also defined.
>>
>> Endian flipping is performed automatically at read and write time, if
>> cross-endianness is detected.
>>
>> ChangeLog:
>>
>> 	* Makefile.def: Add libctfframe as new module with its
>> 	dependencies.
>> 	* Makefile.in: Regenerated.
>> 	* binutils/Makefile.am: Add libctfframe.
>> 	* binutils/Makefile.in: Regenerated.
>> 	* configure: Regenerated
>> 	* configure.ac: Add libctfframe to host_libs.
>> 	* libctfframe/Makefile.am: New file.
>> 	* libctfframe/Makefile.in: New file.
>> 	* libctfframe/aclocal.m4: New file.
>> 	* libctfframe/config.h.in: New file.
>> 	* libctfframe/configure: New file.
>> 	* libctfframe/configure.ac: New file.
>> 	* libctfframe/ctf-frame-error.c: New file.
>> 	* libctfframe/ctf-frame-impl.h: New file.
>> 	* libctfframe/ctf-frame.c: New file.
>>
>> include/ChangeLog:
>>
>> 	* ctf-frame-api.h: New file.
>> ---
>>   Makefile.def                  |     2 +
>>   Makefile.in                   |  1288 ++-
>>   binutils/Makefile.am          |     2 +
>>   binutils/Makefile.in          |     1 +
>>   configure                     |     2 +-
>>   configure.ac                  |     2 +-
>>   include/ctf-frame-api.h       |   210 +
>>   libctfframe/Makefile.am       |    38 +
>>   libctfframe/Makefile.in       |   915 ++
>>   libctfframe/aclocal.m4        |  1241 +++
>>   libctfframe/config.h.in       |   144 +
>>   libctfframe/configure         | 15118 ++++++++++++++++++++++++++++++++
>>   libctfframe/configure.ac      |    75 +
>>   libctfframe/ctf-frame-error.c |    49 +
>>   libctfframe/ctf-frame-impl.h  |    55 +
>>   libctfframe/ctf-frame.c       |  1515 ++++
>>   16 files changed, 20650 insertions(+), 7 deletions(-)
>>   create mode 100644 include/ctf-frame-api.h
>>   create mode 100644 libctfframe/Makefile.am
>>   create mode 100644 libctfframe/Makefile.in
>>   create mode 100644 libctfframe/aclocal.m4
>>   create mode 100644 libctfframe/config.h.in
>>   create mode 100755 libctfframe/configure
>>   create mode 100644 libctfframe/configure.ac
>>   create mode 100644 libctfframe/ctf-frame-error.c
>>   create mode 100644 libctfframe/ctf-frame-impl.h
>>   create mode 100644 libctfframe/ctf-frame.c
>>
> 
> Hi,
> 
> This patch did not make to the list as it exceeds the 400 KB limit
> 
> --------------
> 
> Your mail to 'Binutils' with the subject
> 
>      [PATCH,RFC 3/7] libctfframe: add the CTF Frame library
> 
> Is being held until the list moderator can review it for approval.
> 
> The reason it is being held:
> 
>      Message body is too big: 666389 bytes with a limit of 400 KB
> 
> -------------
> 
> What is the recommended way to address this ? Splitting this patch up 
> with libctfframe/configure in a separate commit will not address the 
> issue as the libctfframe/configure will still be larger than 400 KB.

A common way around this is to supply the patch as an attachment instead,
possibly even compressed. Typically such large patches are mostly
mechanical changes (or even changes to generated files, as looks to be
the case here), and hence fair parts of the patch won't need commenting
on. It can therefore make sense to attach the full patch, but at the
same time inline the non-mechanical parts for easier commenting. Such
splitting will of course want pointing out very prominently.

Jan