From: Jan Beulich <jbeulich@suse.com>
To: "Cui, Lili" <lili.cui@intel.com>
Cc: Binutils <binutils@sourceware.org>, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] x86/Intel: test non-legacy VCVT{,U}SI2SH insn forms
Date: Thu, 19 May 2022 07:53:54 +0200 [thread overview]
Message-ID: <0dd4d99f-b2e1-df2d-5f93-007511743c60@suse.com> (raw)
In-Reply-To: <SJ0PR11MB5600508F08548E60564FAE5C9ED09@SJ0PR11MB5600.namprd11.prod.outlook.com>
On 19.05.2022 03:21, Cui, Lili wrote:
>
>
>> -----Original Message-----
>> From: Binutils <binutils-bounces+lili.cui=intel.com@sourceware.org> On
>> Behalf Of H.J. Lu via Binutils
>> Sent: Thursday, May 19, 2022 1:39 AM
>> To: Beulich, Jan <JBeulich@suse.com>
>> Cc: Binutils <binutils@sourceware.org>
>> Subject: Re: [PATCH] x86/Intel: test non-legacy VCVT{,U}SI2SH insn forms
>>
>> On Mon, Apr 11, 2022 at 11:57 PM Jan Beulich <jbeulich@suse.com> wrote:
>>>
>>> For an unclear reason corresponding AVX512F tests were apparently not
>>> cloned or used as reference here, and instead the bogus legacy forms
>>> of the insns (with the embedded rounding specifier not last) were used.
>>> ---
>>> Ideally the legacy forms wouldn't have been supported by gas in the
>>> first place, but I guess it's too late now for correcting this mistake.
>>>
>>> Note that in some other (pre-FP16) tests we also have some legacy
>>> instances left. Perhaps we want to retain those for making sure they
>>> continue to work even if modern code better wouldn't use them.
>>> Ultimately even those forms aren't MASM-compatible, but I'll get to
>>> that later.
>>>
>
> Hi Jan, I also found some other similar cases, and I will create a patch to fix them later. Thanks!
I'm not sure we want to eliminate / replace all of them - see what I've
said above. After all we want the assembler to continue to accept this
form, for not breaking code pre-dating the introduction of the partly
(and now also the fully) SDM-compatible form.
Jan
> gas/testsuite/gas/i386/evex-lig.s: vcvtsi2ss xmm6, xmm5, {rn-sae}, eax # AVX512
> gas/testsuite/gas/i386/evex-lig.s: vcvtsi2ss xmm6, xmm5, {rn-sae}, ebp # AVX512
> gas/testsuite/gas/i386/evex-lig.s: vcvtusi2ss xmm6, xmm5, {rn-sae}, eax # AVX512
> gas/testsuite/gas/i386/evex-lig.s: vcvtusi2ss xmm6, xmm5, {rn-sae}, ebp # AVX512
>
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtsi2sd xmm30, xmm29, {rn-sae}, rax # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtsi2sd xmm30, xmm29, {rn-sae}, r8 # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtsi2ss xmm30, xmm29, {rn-sae}, eax # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtsi2ss xmm30, xmm29, {rn-sae}, ebp # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtsi2ss xmm30, xmm29, {rn-sae}, r13d # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtsi2ss xmm30, xmm29, {rn-sae}, rax # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtsi2ss xmm30, xmm29, {rn-sae}, r8 # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtusi2sd xmm30, xmm29, {rn-sae}, rax # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtusi2sd xmm30, xmm29, {rn-sae}, r8 # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtusi2ss xmm30, xmm29, {rn-sae}, eax # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtusi2ss xmm30, xmm29, {rn-sae}, ebp # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtusi2ss xmm30, xmm29, {rn-sae}, r13d # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtusi2ss xmm30, xmm29, {rn-sae}, rax # AVX512
> gas/testsuite/gas/i386/x86-64-evex-lig.s: vcvtusi2ss xmm30, xmm29, {rn-sae}, r8 # AVX512
>
> Lili.
next prev parent reply other threads:[~2022-05-19 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 6:57 Jan Beulich
2022-05-18 17:38 ` H.J. Lu
2022-05-19 1:21 ` Cui, Lili
2022-05-19 5:53 ` Jan Beulich [this message]
2022-05-19 6:14 ` Cui, Lili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dd4d99f-b2e1-df2d-5f93-007511743c60@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=lili.cui@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).