gas/write.c - infinite loop

gas/write.c - infinite loop

[James Lemke]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

I came across a problem with gas hanging recently.  The attached patch
was the fix.  It seems obvious, but I'm boot strapping on i686-linux
now.

comments?  OK for mainline?
Jim.

-- 
James Lemke   jim@wasabisystems.com   Orillia, Ontario
http://www.wasabisystems.com

[-- Attachment #2: gas-write.c-patch --]
[-- Type: text/x-patch, Size: 1054 bytes --]

Index: gas/ChangeLog
===================================================================
RCS file: /cvs/src/src/gas/ChangeLog,v
retrieving revision 1.2371
diff -u -p -r1.2371 ChangeLog
--- gas/ChangeLog	23 Feb 2005 12:28:01 -0000	1.2371
+++ gas/ChangeLog	24 Feb 2005 16:22:13 -0000
@@ -1,3 +1,7 @@
+2005-02-24  James Lemke  <jim@wasabisystems.com>
+
+	* write.c (write_object_file): Make link update unconditional.
+
 2005-02-23  Alan Modra  <amodra@bigpond.net.au>
 
 	* cgen.c: Warning fixes.
Index: gas/write.c
===================================================================
RCS file: /cvs/src/src/gas/write.c,v
retrieving revision 1.82
diff -u -p -r1.82 write.c
--- gas/write.c	7 Feb 2005 03:13:10 -0000	1.82
+++ gas/write.c	24 Feb 2005 16:22:14 -0000
@@ -1474,8 +1474,7 @@ write_object_file (void)
 	    bfd_section_list_remove (stdoutput, seclist);
 	    stdoutput->section_count--;
 	  }
-	else
-	  seclist = &(*seclist)->next;
+	seclist = &(*seclist)->next;
       }
     i = 0;
     bfd_map_over_sections (stdoutput, renumber_sections, &i);

Re: gas/write.c - infinite loop

[Nick Clifton]

Hi Jim,

> I came across a problem with gas hanging recently.  The attached patch
> was the fix.  It seems obvious, but I'm boot strapping on i686-linux
> now.
> 
> comments? 

Do you have a testcase ?

> OK for mainline?

Maybe, but I would like to know more about the problem first.

Cheers
   Nick

Re: gas/write.c - infinite loop

[James Lemke]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

On Thu, 2005-02-24 at 12:25, Nick Clifton wrote:
> Hi Jim,
> 
> > I came across a problem with gas hanging recently.  The attached patch
> > was the fix.  It seems obvious, but I'm boot strapping on i686-linux
> > now.
> > 
> > comments? 
> 
> Do you have a testcase ?
I was compiling hello.c with a mingw x xscale configuration.
(xscale-elf-gcc.exe -o hello.x hello.c)

The problem did not show up for i686-linux x xscale.
A regression test for this config should be complete soon.

Jim.

-- 
James Lemke   jim@wasabisystems.com   Orillia, Ontario
http://www.wasabisystems.com

[-- Attachment #2: hello.c --]
[-- Type: text/x-csrc, Size: 99 bytes --]

#include <stdio.h>

int main( int argc, char *argv[])
{
        printf( "hello world!\n");
}

Re: gas/write.c - infinite loop

[James Lemke]

> The problem did not show up for i686-linux x xscale.
> A regression test for this config should be complete soon.
No regressions, results were identical.

-- 
James Lemke   jim@wasabisystems.com   Orillia, Ontario
http://www.wasabisystems.com

Re: gas/write.c - infinite loop

[Alan Modra]

On Thu, Feb 24, 2005 at 11:31:01AM -0500, James Lemke wrote:
> I came across a problem with gas hanging recently.  The attached patch
> was the fix.  It seems obvious, but I'm boot strapping on i686-linux

Not OK.  I don't believe there is a problem with this piece of code.
ie. You are working around a compiler bug, and in any case your patch is
incorrect.  See the definition of bfd_section_list_remove.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: gas/write.c - infinite loop

[James Lemke]

On Thu, 2005-02-24 at 20:23, Alan Modra wrote:
> On Thu, Feb 24, 2005 at 11:31:01AM -0500, James Lemke wrote:
> > I came across a problem with gas hanging recently.  The attached patch
> > was the fix.  It seems obvious, but I'm boot strapping on i686-linux
> 
> Not OK.  I don't believe there is a problem with this piece of code.
> ie. You are working around a compiler bug, and in any case your patch is
> incorrect.  See the definition of bfd_section_list_remove.

Hmmm.  bfd_section_list_remove does do the right thing.  So there must
be a problem with my build compiler.  Thanks Alan.

Withdrawn.

-- 
James Lemke   jim@wasabisystems.com   Orillia, Ontario
http://www.wasabisystems.com