public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@cygnus.com>
To: "Jerry Quinn" <jquinn@nortelnetworks.com>
Cc: binutils@sourceware.cygnus.com
Subject: Re: Patch: fix parens in tc-hppa.c
Date: Thu, 23 Sep 1999 07:45:00 -0000	[thread overview]
Message-ID: <11704.938097735@upchuck.cygnus.com> (raw)
In-Reply-To: <199909221907.MAA25706@cygnus.com>

  In message <199909221907.MAA25706@cygnus.com>you write:
  > tc-hppa.c was a bit broken here.  This patch fixes it so things compile.
  > 
  > Jerry
  > 
  > Wed Sep 22 15:03:11 EDT 1999  Jerry Quinn <jerry.quinn.adv91@alum.dartmouth
  > .org>
  > 
  >     * gas/config/tc-hppa.c (pa_ip):  Fix mismatched parentheses.
!?!  The ChangeLog has no correlation to the patch itself.  The patch zapped 
the
'e' operand (used by some of the FP loads/stores).  I'm not sure what you
were really trying to do here.


  > 
  > 
  > *** orig/gas/config/tc-hppa.c	Wed Sep 22 11:50:54 1999
  > --- gas-src/gas/config/tc-hppa.c	Wed Sep 22 14:28:28 1999
  > ***************
  > *** 3700,3734 ****
  >   			opcode |= (result.l_r_select & 1) << 1;
  >   		      }
  >   		    continue;
  >   		default:
  >   		  abort ();
  >   		}
  >   	      break;
  >   
  > ! 	    /* Handle L/R register halves like 'x'.  */
  > ! 	    case 'e':
  > ! 	      {
  > ! 		struct pa_11_fp_reg_struct result;
  > ! 
  > ! 		/* This should be more strict.  Small steps.  */
  > ! 		if (strict && *s != '%')
  > ! 		  break;
  > ! 		pa_parse_number (&s, &result);
  > ! 		CHECK_FIELD (result.number_part, 31, 0, 0);
  > ! 		opcode |= (result.number_part & 0x1f) << 16;
  > ! 		if (need_pa11_opcode (&the_insn, &result))
  > ! 		  {
  > ! 		    opcode |= (result.l_r_select & 1) << 1;
  > ! 		  }
  > ! 		continue;
  > ! 	      }
  > ! 
  >   	    default:
  >   	      abort ();
  >   	    }
  >   	  break;
  >   	}
  > ! 
  >    failed:
  >         /* Check if the args matched.  */
  >         if (match == FALSE)
  > --- 3700,3720 ----
  >   			opcode |= (result.l_r_select & 1) << 1;
  >   		      }
  >   		    continue;
  > + 		  }
  > + 
  > + 		/* Error case for float registers. */
  >   		default:
  >   		  abort ();
  >   		}
  >   	      break;
  >   
  > ! 	    /* Error case for all codes. */
  >   	    default:
  >   	      abort ();
  >   	    }
  >   	  break;
  >   	}
  > ! 	  
  >    failed:
  >         /* Check if the args matched.  */
  >         if (match == FALSE)
  > 
  > 


       reply	other threads:[~1999-09-23  7:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <199909221907.MAA25706@cygnus.com>
1999-09-23  7:45 ` Jeffrey A Law [this message]
1999-09-22 12:07 Jerry Quinn
  -- strict thread matches above, loose matches on Subject: below --
1999-09-22 12:07 Jerry Quinn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11704.938097735@upchuck.cygnus.com \
    --to=law@cygnus.com \
    --cc=binutils@sourceware.cygnus.com \
    --cc=jquinn@nortelnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).